Adds HTTP/2 support to Consul's HTTPS server. #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this with https://github.com/slackpad/consul-live, where the |
preetapan
reviewed
Nov 13, 2017
| if err := http2.ConfigureTransport(transport); err != nil { | ||
| t.Fatalf("err: %v", err) | ||
| } | ||
| hc := &http.Client{ |
There was a problem hiding this comment.
Any reason not to wire up http2 transport when tls settings are provided in API client we create for the CLI here?
There was a problem hiding this comment.
I wanted to leave things in the default configuration for now and then flip the API client's default before the next major release, which will turn on HTTP/2 for anything using TLS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If TLS is enabled, Consul will now support HTTP/2 for suitably configured clients. This allows them to multiplex multiple requests over the same TCP connection, such as multiple blocking queries. We have not yet made the Go API client default to using HTTP/2, but we've left a TODO to do that in a future major release.