Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to health check definition #367

Closed
cruatta opened this issue Sep 25, 2014 · 8 comments
Closed

Add tags to health check definition #367

cruatta opened this issue Sep 25, 2014 · 8 comments
Labels
theme/service-metadata Anything related to management/tracking of service metadata type/enhancement Proposed improvement or new feature

Comments

@cruatta
Copy link
Contributor

cruatta commented Sep 25, 2014

Now that we have a watch system, having tags in health check definitions would allow you to get very intelligent about routing status information once it's been passed to an alerting system. You could, for instance, tag a check as "dba" so that when it alerts, your alert routing system passes this on to your DBA on call team.

@armon armon added the type/enhancement Proposed improvement or new feature label Oct 14, 2014
@mgmonteleone
Copy link

This was exactly what we were looking for.

Vote up...

@blalor
Copy link
Contributor

blalor commented Oct 22, 2014

+1 for moar tags

@petemounce
Copy link

Doesn't http://flapjack.io/ support something similar to this? I saw there was a consul-flapjack connector... However, I think this becomes more useful if #562 (multiple checks per service) is supported?

@mfischer-zd
Copy link
Contributor

See also #418 (comment)

@hugochinchilla
Copy link

+1

@adrianlop
Copy link

yeah great idea, we need this too. the problem is that you can only filter using tags in consul watch -type service, but it'd be very useful with serviceS or checks type, right?

any update on this?

@slackpad slackpad added this to the 0.7.3 milestone Nov 17, 2016
@slackpad slackpad modified the milestones: 0.7.4, 0.7.3 Jan 17, 2017
@slackpad slackpad removed this from the Triaged milestone Apr 18, 2017
@slackpad slackpad added the theme/service-metadata Anything related to management/tracking of service metadata label May 2, 2017
@koalalam
Copy link

+1, any update on this?

@hanshasselberg
Copy link
Member

This issue is very old, yet relevant. These days, services can be tagged and health checks can be bound to a service. Which should solve your problem. I am closing this issue, because it is ancient. If you think this still deserves an open issue, feel free to create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/service-metadata Anything related to management/tracking of service metadata type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests