Make sure revokeLeadership is called if establishLeadership errors #3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyhavlov
approved these changes
Feb 21, 2018
agent/consul/server_test.go
Outdated
| defer os.RemoveAll(dir1) | ||
| defer s1.Shutdown() | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports over a fix from @dadgar in Nomad (hashicorp/nomad#3890) that leaves partially initialized state around when the establishLeadership method returns an error. This caused us to not call revokeLeadership if there was an event in the stop channel (losing leadership).
This, combined with #3908 makes sure that revokeLeadership is idempotent.