Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make limits a reloadable configuration #4012

Closed
guidoiaquinti opened this issue Apr 4, 2018 · 1 comment · Fixed by #4019
Closed

Make limits a reloadable configuration #4012

guidoiaquinti opened this issue Apr 4, 2018 · 1 comment · Fixed by #4019
Labels
theme/config Relating to Consul Agent configuration, including reloading type/enhancement Proposed improvement or new feature

Comments

@guidoiaquinti
Copy link
Contributor

Description of the Issue (and unexpected/desired result)

Right now it's not possible to apply limit changes without a restart. It could be nice make them a reloadable configuration.

Reproduction steps

  • edit limits in the config
  • send a SIGHUP to consul
  • limits are not refreshed at runtime
@mkeeler mkeeler added type/enhancement Proposed improvement or new feature theme/config Relating to Consul Agent configuration, including reloading labels Apr 5, 2018
@jwasinger
Copy link
Contributor

If it's alright, I'd like to make an attempt at this issue. It's been awhile since I made contributions to Consul and it would be nice to get some more :)

@jwasinger jwasinger mentioned this issue Apr 8, 2018
Merged
@mkeeler mkeeler mentioned this issue Jun 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/config Relating to Consul Agent configuration, including reloading type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make limits a reloadable configuration jwasinger/consul
3 participants
@mkeeler @jwasinger @guidoiaquinti