Check ACLs more often for xDS endpoints. #5237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
added
the
theme/connect
|
|
banks
approved these changes
Jan 21, 2019
mkeeler
requested changes
Jan 22, 2019
I actually wrote this against a real envoy setup first and wrote the test after the fact. |
mkeeler
approved these changes
Jan 22, 2019
For established xDS gRPC streams recheck ACLs for each DiscoveryRequest or DiscoveryResponse. If more than 5 minutes has elapsed since the last ACL check, recheck even without an incoming DiscoveryRequest or DiscoveryResponse. ACL failures will terminate the stream.
rboyer
force-pushed
the
term-grpc-stream-on-token-failure
branch
from
7c34dbd to
d3eb781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for xDS endpoints we only check ACL permissions when the gRPC streaming call is initiated. As this is a stream it could have a long life and if the Token is deleted or the attached Policy rules change while the stream is active nothing will re-assert ACLs.
This change will now check ACL permissions on each incoming
DiscoveryRequestor outgoingDiscoveryResponseas one would do for a more traditional direct (non-streaming) RPC.In the event that a stream remains open and blocked but there is no request/response activity, after 5 minutes elapse the stream handler will unblock long enough to recheck ACL permissions.
If the Token has been deleted or the Policies provide insufficient privileges the server will terminate the stream.