Use the correct check duration fields when converting transaction ops #5553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the HTTP endpoint for the transaction API where the health check definition struct wasn't being deserialized properly. In the custom unmarshaling logic here we write the value of Interval/Timeout/DeregisterCriticalServiceAfter to both the new and old fields (which is covered in the go client txn tests here), but the HTTP endpoint doesn't actually end up calling the custom unmarshaler because we decode the body of the request to a generic
interface{}. To get around this, the change has the HTTP endpoint use the old field names instead, which will always be set if they're provided in the request.Fixes #5477.