Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor directory causes type mismatch #5937

Closed
asim opened this issue Jun 8, 2019 · 3 comments · Fixed by #5943
Closed

Vendor directory causes type mismatch #5937

asim opened this issue Jun 8, 2019 · 3 comments · Fixed by #5943

Comments

@asim
Copy link

asim commented Jun 8, 2019

The recent commit of the vendor directoy causes a type mismatch in our use of the consul api.

go-micro/registry/consul/watcher.go:48:33: cannot use cr.Client (type *"github.com/hashicorp/consul/api".Client) as type *"github.com/hashicorp/consul/vendor/github.com/hashicorp/consul/api".Client in argument to wp.RunWithClientAndLogger
go-micro/registry/consul/watcher.go:213:37: cannot use cw.r.Client (type *"github.com/hashicorp/consul/api".Client) as type *"github.com/hashicorp/consul/vendor/github.com/hashicorp/consul/api".Client in argument to wp.RunWithClientAndLogger

Is it possible to correct the referencing for this?

@mkeeler
Copy link
Member

mkeeler commented Jun 8, 2019

Definitely. I am not at my laptop at the moment to PR this but it should only require running make update-vendor as that will remove consul from the vendor dir

@Rochfort
Copy link

Can I ask you to commit with make update-vendor command because it breaks all the builds in CI?

@mkeeler
Copy link
Member

mkeeler commented Jun 10, 2019

It will be done hopefully in the next half hour or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants