api: Adding Lock helpers for leader election #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Set that we no longwer own the lock | ||
| l.isHeld = false |
There was a problem hiding this comment.
I think we need to set this just before returning. Otherwise if we fail to release the lock, this gets set to false anyways.
There was a problem hiding this comment.
The only thing that can fail is the KV.Release() but we have to assume the lock is no longer held once that call is started.
|
@armon I left 1 comment, but otherwise everything LGTM! Super awesome. |
| return ErrLockNotHeld | ||
| } | ||
|
|
||
| // Set that we no longwer own the lock |
There was a problem hiding this comment.
Typo. s/longwer/longer/. :-)
armon
added a commit
that referenced
this pull request
Jan 12, 2015
api: Adding Lock helpers for leader election
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
Lockto the client API. This can be used to implement simple leader election or mutual exclusion via Consul. Modeled on: https://consul.io/docs/guides/leader-election.html