New "maint" command #625
Merged
New "maint" command #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1039,12 +1039,17 @@ func (a *Agent) EnableServiceMaintenance(serviceID string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Use default notes if no reason provided | |||
| if reason == "" { | |||
| reason = "Maintenance mode is enabled for this service" | |||
There was a problem hiding this comment.
Should we make this a constant like DefaultReason? I also think we should have some text like "no reason provided" somewhere in there, maybe in parenthesis?
There was a problem hiding this comment.
Agreed on the constant. Also a recommendation to make this a bit more verbose and add verbiage such as: "No specific reason was provided. This is a default message."
|
Added "list mode" to the |
|
LGTM! 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
consul maintcommand, which utilizes the new service/node maintenance mode API's to enable or disable maintenance mode from the CLI. This will make it easy to do something along the lines ofAs part of this, I've also added the
reasonargument and associated API query parameters. This allows passing a reason for entering maintenance mode. If none is provided, a default is used.