Support ACL upsert behavior #909
Merged
+90
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! And as someone managing a largish deployment, this is a huge win for DR. It's much easier to reassert a set of ACLs than to update tokens on all clients. |
|
Nice! We struggled with this too. |
3 tasks
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
* update changelog for tproxy connect refactor Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #777. Previously, there was an ACL create endpoint, which did not permit providing an ID and always randomly generated an ID. There was also an update endpoint, which required an ID and that the ACL must exist.
This meant it was not possible to restore tokens (from backup) since the token ID was always re-generated. It also made it difficult to generate an ID external to Consul, which can be useful for systems like Vault.
This PR changes the behavior to an upsert. If an ID is not provided, a random UUID will be generated. Create and Update do not require the ACL to exist already, allowing for ACL restoration or external generation.
This should not break any existing clients, but enables some new use cases. However, there is basically no difference between create and update, but the endpoints must exist for backwards compatibility reasons.