-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Lots of instances of a service break out of it's bounding box #938
Comments
Thanks for reporting this, marking as a bug! /cc @pearkes @markupboy |
@ryanbreen fwiw, this happens similarly as well for Lock Sessions: |
I've run into this all over the place as well. I'd be interested in contributing a patch and I've already fixed several instances of this on our local cluster. The main offender here is setting explicit element heights in Ember's ListView. Personally, I've found the nested scrolling UI buggy and distracting and have opted to just remove it altogether. If no one is attached to the nested scrolling, I can submit a PR. Thoughts? |
@rafikk Agreed about the nested scrolling, but unfortunately it's for performance. In large clusters (thousands of services/nodes) the UI chokes without ember listview. |
@pearkes Does that mean removing ListView is a non-starter? Is pagination an option? Is there a good way for me to test the UI against such a cluster? |
@rafikk Best way to test the UI is to replace the JSON endpoint to a json file on disk (the ui dir serves a directory, so you can just copy a file in there). Then give the file a fake response of some 1000s of nodes. That's the best way I remember. Proper fixtures would be nice though. Ember has a come a long way since this UI was made, so there are a number of "better" tools now as well. |
I've got instances of this happening with very long node and check names. Long check names push the status down to where it is almost illegible. |
Long node names also cause issues on the |
Kicking over to @meirish who's been looking into some UI bugs. |
Hey there, We are currently hiring for a full time position to manage the Consul UI. They are going to do a full revamp, so we'll make sure this is included then! |
Should be pretty self explanatory:
The text was updated successfully, but these errors were encountered: