Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Lots of instances of a service break out of it's bounding box #938

Closed
mattrobenolt opened this issue May 15, 2015 · 10 comments
Closed
Labels
archived/webui This was used for v1/ui

Comments

@mattrobenolt
Copy link

Should be pretty self explanatory:

image

@ryanuber ryanuber added the type/bug Feature does not function as expected label May 29, 2015
@ryanuber
Copy link
Member

Thanks for reporting this, marking as a bug! /cc @pearkes @markupboy

@mattrobenolt
Copy link
Author

@ryanbreen fwiw, this happens similarly as well for Lock Sessions:

image

@rafikk
Copy link
Contributor

rafikk commented Jun 2, 2015

I've run into this all over the place as well.

I'd be interested in contributing a patch and I've already fixed several instances of this on our local cluster. The main offender here is setting explicit element heights in Ember's ListView. Personally, I've found the nested scrolling UI buggy and distracting and have opted to just remove it altogether. If no one is attached to the nested scrolling, I can submit a PR.

Thoughts?

@pearkes
Copy link
Contributor

pearkes commented Jun 2, 2015

@rafikk Agreed about the nested scrolling, but unfortunately it's for performance. In large clusters (thousands of services/nodes) the UI chokes without ember listview.

@rafikk
Copy link
Contributor

rafikk commented Jun 2, 2015

@pearkes Does that mean removing ListView is a non-starter? Is pagination an option?

Is there a good way for me to test the UI against such a cluster?

@pearkes
Copy link
Contributor

pearkes commented Jun 3, 2015

@rafikk Best way to test the UI is to replace the JSON endpoint to a json file on disk (the ui dir serves a directory, so you can just copy a file in there). Then give the file a fake response of some 1000s of nodes. That's the best way I remember. Proper fixtures would be nice though. Ember has a come a long way since this UI was made, so there are a number of "better" tools now as well.

@nickwales
Copy link
Contributor

I've got instances of this happening with very long node and check names.

Long check names push the status down to where it is almost illegible.
Long service names break out of their bounding boxes on the services view.

@macb
Copy link

macb commented Oct 26, 2015

Long node names also cause issues on the nodes endpoint (pushes the Deregister button around)

@slackpad slackpad assigned slackpad and meirish and unassigned slackpad Oct 26, 2015
@slackpad
Copy link
Contributor

Kicking over to @meirish who's been looking into some UI bugs.

@meirish meirish added the archived/webui This was used for v1/ui label Oct 26, 2015
@slackpad slackpad removed the type/bug Feature does not function as expected label Nov 22, 2016
@slackpad slackpad added this to the 0.7.4 milestone Nov 22, 2016
@slackpad slackpad removed this from the Triaged milestone Apr 18, 2017
@slackpad
Copy link
Contributor

slackpad commented May 2, 2017

Hey there,

We are currently hiring for a full time position to manage the Consul UI. They are going to do a full revamp, so we'll make sure this is included then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived/webui This was used for v1/ui
Projects
None yet
Development

No branches or pull requests

8 participants