Fixing memory leak caused by blocking query #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -421,6 +421,13 @@ func (s *StateStore) Watch(tables MDBTables, notify chan struct{}) { | |||
| } | |||
| } | |||
|
|
|||
| // StopWatch is used to unsubscribe a channel to a set of MDBTables | |||
| func (s *StateStore) StopWatch(tables MDBTables, notify chan struct{}) { | |||
There was a problem hiding this comment.
I think we are missing a test for this function
|
@armon everything looks great, just one untested method. Otherwise LGTM! |
|
@ryanuber Added test! |
armon
added a commit
that referenced
this pull request
May 15, 2015
Fixing memory leak caused by blocking query
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking queries work by registering a notification channel along various write paths and watching for trigger to be hit. Once triggered, those channels are notified and cleared. However, for many blocking queries, their trigger point may not be hit for a long (potentially infinite) time, causing a memory leak. To avoid this, this PR changes behavior to pro-actively clear the notification channels and timeout timers. This avoids the leaks caused by blocking queries.