Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: use the presense of stored federation state data as a sign that we already activated the federation state feature flag #9519

Merged
merged 2 commits into from
Jan 25, 2021
Merged

server: use the presense of stored federation state data as a sign that we already activated the federation state feature flag #9519

merged 2 commits into from
Jan 25, 2021

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jan 6, 2021

This way we only have to wait for the serf barrier to pass once before
we can make use of federation state APIs Without this patch every
restart needs to re-compute the change.

@rboyer rboyer requested a review from a team January 6, 2021 23:26
@rboyer rboyer self-assigned this Jan 6, 2021
@rboyer
Copy link
Member Author

rboyer commented Jan 6, 2021

This is similar to #9505

@rboyer rboyer force-pushed the sticky-fedstate-feature branch from e548900 to ada6506 Compare January 7, 2021 21:50
banks
banks approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rboyer added 2 commits January 25, 2021 13:22
@rboyer
server: use the presense of stored federation state data as a sign th…
50fc7ca 
…at we already activated the federation state feature flag

This way we only have to wait for the serf barrier to pass once before
we can make use of federation state APIs Without this patch every
restart needs to re-compute the change.
@rboyer
add changelog
fc8e5cf
@rboyer rboyer force-pushed the sticky-fedstate-feature branch from ada6506 to fc8e5cf Compare January 25, 2021 19:24
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 25, 2021 19:24 Inactive
@vercel vercel bot temporarily deployed to Preview – consul January 25, 2021 19:24 Inactive
@rboyer rboyer merged commit 51e3ca6 into master Jan 25, 2021
@rboyer rboyer deleted the sticky-fedstate-feature branch January 25, 2021 19:24
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/316598.

@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/319205.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 51e3ca6 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Jan 28, 2021
@rboyer @hashicorp-ci
server: use the presense of stored federation state data as a sign th…
fa9b61b 
…at we already activated the federation state feature flag (#9519)

This way we only have to wait for the serf barrier to pass once before
we can make use of federation state APIs Without this patch every
restart needs to re-compute the change.
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/319207.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 51e3ca6 onto release/1.9.x succeeded!

@dnephin dnephin mentioned this pull request Jan 28, 2021
Closed
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/324604.

@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit 51e3ca6 onto release/1.9.x failed! Build Log

@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/324606.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 51e3ca6 onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 8, 2021
@rboyer @hashicorp-ci
server: use the presense of stored federation state data as a sign th…
556b8bd 
…at we already activated the federation state feature flag (#9519)

This way we only have to wait for the serf barrier to pass once before
we can make use of federation state APIs Without this patch every
restart needs to re-compute the change.
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
@rboyer rboyer mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banks banks banks approved these changes

Assignees

@rboyer rboyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rboyer @hashicorp-ci @banks @dnephin