Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix envoy canBind #6238

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Fix envoy canBind #6238

merged 2 commits into from
Jul 30, 2019

Conversation

mkeeler
Copy link
Member

@mkeeler mkeeler commented Jul 29, 2019

The string form of an Addr was including the CIDR causing the str equals to not match.

@mkeeler
Fix envoy cli canBind function
c5a0f31 
The string form of an Addr was including the CIDR causing the str equals to not match.
@mkeeler mkeeler added this to the 1.6.0-beta4 milestone Jul 29, 2019
@mkeeler mkeeler requested a review from a team July 29, 2019 17:47
hanshasselberg
hanshasselberg approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkeeler mkeeler merged commit 1fdda51 into release/1-6 Jul 30, 2019
@mkeeler mkeeler deleted the fix-envoy-canBind branch July 30, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanshasselberg hanshasselberg hanshasselberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@mkeeler @hanshasselberg