[HVS] Support Pagination in run Command #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinnyHC
commented
Aug 20, 2024
| if err != nil { | ||
| return nil, err | ||
| } else if len(secs) == 0 { | ||
| return nil, fmt.Errorf("no secrets returned from app") |
There was a problem hiding this comment.
I think this is a reasonable UX improvement but happy to remove if folks don't think its needed
There was a problem hiding this comment.
Is there a story where you'd want to "run" even if the list is empty?
There was a problem hiding this comment.
Yeah great question. I suppose this is a breaking change and probably best removed.
I can think of a situation where you push app code that no longer needs secrets and you delete them from HVS but your tooling is still launching the app via hcp vs run
There was a problem hiding this comment.
Removed in 526b17d , we can add later if we want it.
dhuckins
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Implement the ability to use
next_page_token's to accumulate secrets from paginated responses.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: