Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sidecar upstreams config #11392

Closed
legege opened this issue Oct 26, 2021 · 5 comments · Fixed by #15761
Closed

Support sidecar upstreams config #11392

legege opened this issue Oct 26, 2021 · 5 comments · Fixed by #15761
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration theme/jobspec theme/networking type/enhancement
Milestone

Comments

@legege
Copy link
Contributor

legege commented Oct 26, 2021

Proposal

It's currently impossible to set advanced configurations on an upstream sidecar service proxy. The proposal here would be to allow a config option, similar to how it's possible directly with Consul:
https://www.consul.io/docs/connect/registration/service-registration#config-1

Use-cases

  1. This would allow the end user to configure proxy-specific features like timeouts or retries for the given upstream. Example:
      proxy {
        upstreams {
          destination_name   = "countdash-api"
          local_bind_port    = 8080

          config {
            connect_timeout_ms = 5000
            limits {
              max_connections         = 3
              max_pending_requests    = 4
              max_concurrent_requests = 5
            }
            passive_health_check {
              interval     = "30s"
              max_failures = 10
            }
          }
        }
      }
  1. It would also allow to use upstream level escape-hatch: envoy_listener_json and envoy_cluster_json
@jrasell jrasell added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration theme/jobspec labels Oct 27, 2021
@jrasell
Copy link
Member

jrasell commented Oct 27, 2021

Hi @legege and thanks for raising this issue which seems like a sensible and nice idea.

@Lord-Y
Copy link

Lord-Y commented Sep 16, 2022

Any news about this issue?

@DerekStrickland
Copy link
Contributor

Hi @Lord-Y

We actually just talked about doing a pass on Consul configuration syncing a couple of hours ago. I've added this issue to the list. Thanks for checking in. The reminder was timely!

@komapa
Copy link

komapa commented Jan 7, 2023

We would really like to also see this implemented. It is a shame that Nomad is not kept up to date with what Consul implements around the Service Mesh.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration theme/jobspec theme/networking type/enhancement
Projects
Development

Successfully merging a pull request may close this issue.

6 participants