Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: general keyboard navigation #12762

Closed
10 of 14 tasks
philrenaud opened this issue Apr 22, 2022 · 5 comments
Closed
10 of 14 tasks

UI: general keyboard navigation #12762

philrenaud opened this issue Apr 22, 2022 · 5 comments
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/enhancement

Comments

@philrenaud
Copy link
Contributor

philrenaud commented Apr 22, 2022

It would be nice to use keyboard commands to navigate the Nomad UI.

I'd like to move between nav/subnav sections with arrow key modifiers, or vim-like go-to keys.

Launch Blockers

Later:

@philrenaud philrenaud self-assigned this Apr 22, 2022
@lgfa29 lgfa29 added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Apr 27, 2022
@mikenomitch
Copy link
Contributor

Some random/incomplete feedback after playing with the vercel link:

  • Do we want to show the key strokes in the middle of the screen? Maybe we could turn that on with some mode? (Maybe this was the plan all along?) - FWIW, I'm not a big fan.

  • Esc causes "Hide Keyboard Shortcuts" to show regardless of whether or not its open

  • If we do show: think showing arrow up/down, and tab, and maybe escape/meta or some others that one would normally get hit in standard keyboard use is probably not great. Maybe we hide these?

  • What I really want is some easy way to select the Nth element from a index page (i.e. Jobs list). I keep hitting "j" to try to jump to the first element of the index (assuming j/k move me up and down the table). Gmail & Fastmail and some other webapps use j/k to do that, and then "o" to open the selected element. IMO that's probably more the expected behavior than switching tabs with j/k. (Maybe shift+j and shift+k and the shift+arrow commands could do the tab switching?)

  • When I do use j/k to tab switch it usually only works once. If I re-click onto the page then re-hit the key, it'll work again. I am on firefox fwiw, so maybe it behaves differently on chrome.

@philrenaud
Copy link
Contributor Author

Do we want to show the key strokes in the middle of the screen? Maybe we could turn that on with some mode? (Maybe this was the plan all along?) - FWIW, I'm not a big fan.

Intent is to never show these; all the associated styles currently in #12831 are for demo purposes only.

What I really want is some easy way to select the Nth element from a index page (i.e. Jobs list). I keep hitting "j" to try to jump to the first element of the index (assuming j/k move me up and down the table). Gmail & Fastmail and some other webapps use j/k to do that, and then "o" to open the selected element. IMO that's probably more the expected behavior than switching tabs with j/k. (Maybe shift+j and shift+k and the shift+arrow commands could do the tab switching?)

I like this as a concept a lot. I think what I might do is remove j and k from subnav/nav traversal, and reserve them for in-page stuff like you mention.

VimCal and a few other info-dense tools do this thing where you hold a key (would probably shift in our case) that annotates all items on your page with its corresponding shortcut. That would probably be the thing that gets us closest number-key-bound list-item opening. Future work I think!

@mikenomitch
Copy link
Contributor

mikenomitch commented May 2, 2022

@philrenaud oh also another idea in the same vein as j/k/o, hitting "u" to traverse up a breadcrumb (ie going from "jobs/JOB_ID" to "/jobs"). Idea taken from Gmail.

@philrenaud
Copy link
Contributor Author

Tackled in #14138 and #14165 — marking complete!

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/enhancement
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants