Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please upgrade vendored consul #6785

Closed
onlyjob opened this issue Nov 28, 2019 · 7 comments · Fixed by #7171
Closed

please upgrade vendored consul #6785

onlyjob opened this issue Nov 28, 2019 · 7 comments · Fixed by #7171

Comments

@onlyjob
Copy link
Contributor

onlyjob commented Nov 28, 2019

At the moment Nomad only builds against Consul 1.4.*.
Nomad FTBFS with Consul 1.5+ because github.com/hashicorp/consul/lib/freeport has been moved to github.com/hashicorp/consul/sdk/freeport.

Furthermore Consul 1.5.3 introduced breaking change to github.com/hashicorp/consul/agent/consul/autopilot that causes the following FTBFS:

src/github.com/hashicorp/nomad/nomad/server_setup_oss.go:15:62: cannot use apDelegate (type *AutopilotDelegate) as type autopilot.Delegate in argument to autopilot.NewAutopilot:
        *AutopilotDelegate does not implement autopilot.Delegate (missing SerfLAN method)

Please consider upgrading vendored Consul.

Thanks.

@onlyjob
Copy link
Contributor Author

onlyjob commented Nov 29, 2019

This commit is responsible for FTBFS against Consul 1.5.3: hashicorp/consul@f09af53

@onlyjob
Copy link
Contributor Author

onlyjob commented Jan 21, 2020

FYI @tgross. Due to this issue I can not upgrade Consul v1.5.2 in Debian... Thanks.

@onlyjob
Copy link
Contributor Author

onlyjob commented Feb 5, 2020

A first fallout of this problem: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950736

Consul is affected by CVE-2020-7219 and CVE-2020-7955 but I can not upgrade Consul in Debian because it will break Nomad. :((

How can I convince you to care more about interoperability, integration and consistency between your own software components?

CC: @tgross.

@tgross
Copy link
Member

tgross commented Feb 5, 2020

As previously discussed, we'll be doing this vendor upgrade in the 0.11 timeframe.

@onlyjob
Copy link
Contributor Author

onlyjob commented Feb 5, 2020

Thanks.

@onlyjob
Copy link
Contributor Author

onlyjob commented Feb 19, 2020

Thanks, @notnoop. Few commits from #7171 is all that was needed. Very helpful.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants