Fix 2022 sysprep provisioner cmd #518
Open
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajolet-hashicorp
previously approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Hey @drewmullen,
Thanks for that PR, the amendment looks good to me; merging now!
lbajolet-hashicorp
force-pushed
the
patch-2
branch
from
677870f to
54f731f
Compare
lbajolet-hashicorp
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sysprep commands currently in the documentation do not work anymore. That is because they are written for EC2Launch v1. V2 moved to new executables in a different location where previously v1 used scripts. v2 is the default for all windows AMIs now as far as i can tell.
The new addition to the docs I have confirmed work for 2022. However, I was not able to get a 2016 or 2019 server working with sysprep provisioners commands. I'm leaving them as is