aws_secretsmanager crashes on non-string JSON values

[ajbdev]

Overview of the Issue

An AWS secret manager JSON secret that contains non-string values will cause packer to crash with a go marshaling error:

template: root:1:3: executing "root" at <aws_secretsmanager
`developmentDBSecret52FA5B0R-RsFGddtv` `host`>: error calling
aws_secretsmanager: json: cannot unmarshal number into Go value of type string

Reproduction Steps

Steps to reproduce this issue

1. Store a secret in AWS secrets manager with a number value. E.g:

{
  "port": 5432
}

2. Use the aws_secretsmanager function to retrieve a secret in a packer config

Observed result: attempting to retrieve any key will throw a JSON marshaling failure.

Packer version

1.6.6

Simplified Packer Buildfile

...
"variables": {
  "var1": "aws_secretsmanger `secretname` `keyname`"
}

Operating system and Environment details

Ubuntu 20 amd64

[ajbdev]

My golang-fu is too weak to know the proper solution here, but I think the offending code is here: https://github.com/hashicorp/packer-plugin-sdk/blob/main/template/interpolate/aws/secretsmanager/secretsmanager.go#L79-L87

[SwampDragons]

Yeah, it looks like the template function only supports string values for secrets; the docs should be clearer on this.

[SwampDragons]

you're right about the location of the issue -- we could probably unmarshal into a map[string]interface{} and cast it into the map[string]string var.

[teddylear]

@SwampDragons I can take a look into this if that's alright

[teddylear]

@SwampDragons I created this PR to address the outlined issue. Please let me know if there's anything that needs to be changed. There is still the question of if this should be changed to return an interface instead of string, but my understanding is that would be a more large scale refactor.

[teddylear]

@SwampDragons This should be able to be closed now that PR is merged.

[azr]

Right ! Thanks @teddylear

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.