Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Add community maintained IPSW data source Packer plugin #12541

Merged

Conversation

torarnv
Copy link
Contributor

@torarnv torarnv commented Jul 26, 2023

No description provided.

@torarnv torarnv requested a review from a team as a code owner July 26, 2023 21:33
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 26, 2023

CLA assistant check
All committers have signed the CLA.

@torarnv
Copy link
Contributor Author

torarnv commented Oct 3, 2023

Ping. What's needed to move this forward? Thanks!

@torarnv
Copy link
Contributor Author

torarnv commented Oct 3, 2023

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @torarnv,

Sorry for letting this one slide, I'll merge it today.

Please note however that we have changed our documentation practices recently, we don't have yet a documentation available for all the plugin developers to work with, but this will be published soon.
In the meantime, I'll merge your PR, and do the necessary steps on our infra code to make it accessible for users of the plugin.

Thanks!

@lbajolet-hashicorp lbajolet-hashicorp added website docs backport/website Backport PR changes to `stable-website` and latest release branch labels Oct 5, 2023
@lbajolet-hashicorp lbajolet-hashicorp merged commit a1722ab into hashicorp:main Oct 5, 2023
15 of 16 checks passed
@torarnv
Copy link
Contributor Author

torarnv commented Oct 6, 2023

Thanks @lbajolet-hashicorp !

@torarnv torarnv deleted the add-ipsw-data-source-plugin branch October 6, 2023 10:41
@torarnv
Copy link
Contributor Author

torarnv commented Oct 6, 2023

@lbajolet-hashicorp Maybe I misunderstood, but were #12648 and #12647 the parts that made the plugin docs available in the current doc infra? It doesn't seem to pop up in the preview at https://packer-4c6dbhdhh-hashicorp.vercel.app/packer/integrations?tiers=community&components=data-source, nor in the current official docs at https://developer.hashicorp.com/packer/integrations?product_intent=packer&tiers=community&components=data-source

No rush, just trying to understand where to look/find them at some point 😃

@lbajolet-hashicorp
Copy link
Contributor

Hi @torarnv,

So, in the past you'd have just needed to merge this, and we'd backport it to the website for it to be available, and it would happen in a not too long delay (depends on when the docs get refreshed based on that branch).

Nowadays with the Integrations workflow, we're changing this a bit, and as I mentioned in my previous comment, this will have an impact on your repo once it's generally available, but in the meantime you did all you had to do for now, I've opened a PR on an internal project to add your repo to the list of integrations, and once it's available you'll be able to access the docs from the Integrations tab on the docs site.

In the meantime, I would think you can access the docs directly, they should already be available (can confirm they are: https://developer.hashicorp.com/packer/plugins/datasources/ipsw). They will become more visible once the PR I opened is merged, and we'll update the docs guides to account for the changes we made in order to adopt the new docs system.

Hope that helps, I would expect the plugin to be visible by next week, but please feel free to reping us on this PR by late next week if it's still not there, at that point we'll see what we can do to unblock that.

@torarnv
Copy link
Contributor Author

torarnv commented Oct 6, 2023

Awesome, thank you so much @lbajolet-hashicorp ❤️

Copy link

github-actions bot commented Nov 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/website Backport PR changes to `stable-website` and latest release branch docs website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants