Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to override nodejs version warnings #1316

Closed
remyleone opened this issue Nov 17, 2021 · 4 comments
Closed

Add option to override nodejs version warnings #1316

remyleone opened this issue Nov 17, 2021 · 4 comments
Labels
enhancement New feature or request upstream/jsii Pending upstream work on JSII

Comments

@remyleone
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

I have the latest version of node.js installed with homebrew:

$ node --version
v17.0.1

When I run cdktf synth in the boilerplate project, I get:

[2021-11-17T16:50:56.708] [ERROR] default - !!                                                                                  !!
!!  This software has not been tested with node v17.0.1.                            !!
!!  You may to encounter runtime issues, and should switch to a supported release.  !!
!!                                                                                  !!
!!  As of the current release, supported versions of node are:                      !!
!!  - ^12.7.0                                                                       !!
!!  - ^14.5.0                                                                       !!
!!  - ^16.3.0                                                                       !!
!!                                                                                  !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Generated Terraform code for the stacks: cdk-go

It is confusing because I get a message labeled as an ERROR and my code is generated anyway.
Could you:

  • Add an option to mute this warning
  • Rename ERROR to warning as it does not prevent the compilation to happen.

References

@remyleone remyleone added enhancement New feature or request new Un-triaged issue labels Nov 17, 2021
@skorfmann skorfmann added the upstream/jsii Pending upstream work on JSII label Nov 18, 2021
@skorfmann
Copy link
Contributor

That's coming from jsii and would have to be addressed over there. At a first glance, I don't see an option to disable it.

Could you please open this as an issue in jsii itself?

@remyleone
Copy link
Author

aws/jsii#1073

@skorfmann
Copy link
Contributor

aws/jsii#1073

I think that's a different scope which is described there. But perhaps it could be added there as well.

Either way, I'm going to close this issue here since that's something which would have to be tackled upstream.

@DanielMSchmidt DanielMSchmidt removed the new Un-triaged issue label Nov 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request upstream/jsii Pending upstream work on JSII
Projects
None yet
Development

No branches or pull requests

3 participants