Use json.Number instead of float64 when parsing state. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State values can contain numbers that are larger than `float64` can
precisely represent. `json.Unmarshal` when unmarshaled into an
`interface{}` uses `float64` to represent numbers by default. To
properly retain precision for numbers, we need to use a custom
`json.Decoder` with the `UseNumber()` method called on it, which will
use `json.Number` (a `string` alias) to store the numbers, preserving
their precision.
|
Can you put a test with like random or something in here that simulates this? |
|
I opened hashicorp/terraform-provider-corner#16, but I can see about doing something inline here, as well? |
kmoe
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
LGTM. Test added in #114, confirmed working with a version of the random provider compiled with hashicorp/terraform-plugin-sdk@b78b8ce.
paultyng
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State values can contain numbers that are larger than
float64canprecisely represent.
json.Unmarshalwhen unmarshaled into aninterface{}usesfloat64to represent numbers by default. Toproperly retain precision for numbers, we need to use a custom
json.Decoderwith theUseNumber()method called on it, which willuse
json.Number(astringalias) to store the numbers, preservingtheir precision.
This does this at the
runTerraformCmdJSONlevel, meaning anyone using that method withvasinterface{}in the arguments will suddenly find that theirfloat64s are nowjson.Numbers, which may break them. The solution to this is to use theFloat64()method on thejson.Number, but it is a code change they will need to make.