Further specify behaviour of terraform show
#273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmoe
force-pushed
the
kmoe/fix-show-test
branch
from
213b6e0 to
2d0945f
Compare
kmoe
commented
Jan 28, 2022
| `run:\s+terraform init`) // v1.1.0 (ref df578afd) | ||
| noInitErrRegexp = regexp.MustCompile( | ||
| // UNINITIALISED PROVIDERS/MODULES | ||
| `Error: Could not satisfy plugin requirements|` + |
There was a problem hiding this comment.
gofmt and I are of differing opinions as to the best indentation for this section of code.
radeksimko
approved these changes
Jan 31, 2022
| @@ -1,4 +1,5 @@ | |||
| // This file contains tests that only compile/work in Go 1.13 and forward | |||
| //go:build go1.13 | |||
There was a problem hiding this comment.
Is it worth running go fmt ./... on the whole project and update all go build lines? Doesn't have to be in this PR though...
On a related note I guess we forgot to update the Readme.md to say that we now require Go 1.17 (as per #216)
There was a problem hiding this comment.
Thanks, I'll add both of those to #272 as a general tidy-up, so we can get this one merged and fix all the other CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nightly
maintest.This PR aims to test all
terraform showscenarios described in hashicorp/terraform#30344, and a few more.Also adds a new error type,
ErrStatePlanRead, which occurs whenterraform showcannot read the state or plan file at the path given.At present, running
terraform show -jsonin a directory with a config file, but in whichterraform inithas not been run, results in inconsistent behaviour across versions:ErrNoInitand exit 1.main(hashicorp/terraform@0d1a04e): Prints empty state ({"format_version":"1.0"}), exit 0.See hashicorp/terraform#30415. The old behaviour is considered incorrect, and is therefore a Terraform CLI known issue prior to v1.2.0.