Add management of TF_APPEND_USER_AGENT #46
Conversation
paultyng
force-pushed
the
ua
branch
2 times, most recently
from
8804e6e to
65dda2f
Compare
| ua := mergeUserAgent( | ||
| os.Getenv(appendUserAgentEnvVar), | ||
| tf.appendUserAgent, | ||
| fmt.Sprintf("HashiCorp-terraform-exec/%s", version.ModuleVersion()), |
There was a problem hiding this comment.
Shouldn't these values be in reverse order? i.e. static HashiCorp-terraform-exec first and then other values being appended, rather than prepended?
There was a problem hiding this comment.
I think it depends. arguably "terraform cloud" or "binary testing" (as the appendUserAgent) is more significant / distinct than terraform exec I think in the case of that system? As there will be many terraform exec apps, so the app itself is the more significant identifier?
There was a problem hiding this comment.
I don't disagree, but the problem is that the ENV variable is called append, not prepend, so we would need to reflect it there somehow (with another/changed variable), else the behaviour won't match the name.
There was a problem hiding this comment.
Thats the common convention in programming but not the english definition of the word. It was a poor original choice for the env var, but its what we have so no option to change it now.
Fixes #9