terraform validate support #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
force-pushed
the
validation
branch
4 times, most recently
from
8880293 to
2121f98
Compare
paultyng
force-pushed
the
json
branch
5 times, most recently
from
78d4598 to
dd030c6
Compare
appilon
force-pushed
the
validation
branch
2 times, most recently
from
f9d65bf to
6ca73f2
Compare
appilon
reviewed
Dec 6, 2020
tfexec/validate_types.go
Outdated
| @@ -0,0 +1,30 @@ | |||
| package tfexec | |||
|
|
|||
| // TODO: move these types to terraform-json | |||
There was a problem hiding this comment.
Is this project 1.0? Would it be a breaking change to export these types, and then move them to tfjson and remove them here?
There was a problem hiding this comment.
I have just raised hashicorp/terraform-json#23 - will see if I can get it merged 🔜 then this would be resolved by just bumping tfjson to the latest version.
kmoe
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
Good stuff. This can go in once hashicorp/terraform-json#23 is merged, so we're not duplicating the types. @radeksimko, hashicorp/terraform-json#23 LGTM but I think the owners of that repo should approve.
Remove validate types as they have moved upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types don't seem to be in terraform-json yet, so need to add those there first.