Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equalToProductOfValidator validator to the int64validator package #129

Merged
merged 2 commits into from
May 2, 2023

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Apr 25, 2023

Closes: #114

This PR adds an equalToProductOfValidator int64 attribute validator that validates whether the configured attribute value is the product of the given attributes. This validator will skip validations if any null or unknown attributes are given.

@SBGoods SBGoods requested a review from a team as a code owner April 25, 2023 19:44
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@bflad bflad added this to the v0.11.0 milestone May 1, 2023
@bflad bflad added the enhancement New feature or request label May 1, 2023
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@SBGoods SBGoods merged commit 6d6816a into main May 2, 2023
@SBGoods SBGoods deleted the equal_product_of_validator branch May 2, 2023 15:26
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiplier validator
3 participants