Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for retrieving tfprotov6.ProviderServer. #72

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

paddycarver
Copy link
Contributor

We need access to the tfprotov6.ProviderServer underlying tfsdk.Serve
for things like testing and muxing. Add a function that will expose it.

@paddycarver paddycarver added the enhancement New feature or request label Jul 18, 2021
@paddycarver paddycarver requested a review from a team July 18, 2021 01:30
We need access to the tfprotov6.ProviderServer underlying `tfsdk.Serve`
for things like testing and muxing. Add a function that will expose it.
@paddycarver paddycarver force-pushed the paddy_proto6_server branch from a30af09 to eaf37c1 Compare July 18, 2021 01:31
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Not sure if it's worth mentioning that this new function is typically used for testing and muxing purposes for future travelers or those going through the Go package documentation.

@paddycarver paddycarver merged commit 10cd055 into main Jul 22, 2021
@paddycarver paddycarver deleted the paddy_proto6_server branch July 22, 2021 16:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants