Fix change detection

[grahamhar]

The change detection failed on maps, this introduces the use of go-cmp
which is better suited to this purpose.

It should fix #617 and the related aws provider issue hashicorp/terraform-provider-aws#15952

Credit to @gdavison for providing the tests.

[lijok]

Can this get reviewed and merged in?
The bug this fixes has us version locked to 3.12.0 aws provider

[dcu]

any news on this one? thanks

[lijok]

This is very concerning
A community contribution that fixes a bug which has people locked to an outdated version of the aws provider, is completely ignored by hashicorp for more than 2 months now
@apparentlymart @bflad is there anything the community can help with to get such pr's progressed further?

[IvDoorn]

This is very concerning
A community contribution that fixes a bug which has people locked to an outdated version of the aws provider, is completely ignored by hashicorp for more than 2 months now
@apparentlymart @bflad is there anything the community can help with to get such pr's progressed further?

Redirecting question to @paddycarver who seems to be most active last couple of months in this repository. :)

[deyvsh]

@kmruddy @pkolyvas-hashicorp Hi gents, I really enjoyed your Terraform 0.15 presentation today, so I hope you don't mind me tagging you here. As you will see from the comments above, it looks like merging this PR would unblock #617, which would in turn unblock hashicorp/terraform-provider-aws#15952, which is causing us a lot of pain every day. Is there anything you can do to help? Thanks!

[grahamhar]

@kmruddy @pkolyvas-hashicorp Hi gents, I really enjoyed your Terraform 0.15 presentation today, so I hope you don't mind me tagging you here. As you will see from the comments above, it looks like merging this PR would unblock #617, which would in turn unblock hashicorp/terraform-provider-aws#15952, which is causing us a lot of pain every day. Is there anything you can do to help? Thanks!

@deyvsh I’ve been reading more about go-cmp and I don’t think it’s the correct approach due to its performance implications. I think this is why the PR is not getting reviewed. I have tried an alternate approach to fix the issue in the AWS provider itself see hashicorp/terraform-provider-aws#17610

[bflad]

Hi @grahamhar 👋 Thank you for submitting this and apologies for the delayed review.

I apologize that I did not see this pull request was similar to #711 before merging that in recently. Looking at the two sets of changes, #711 also updated Set to use cmp.Equal(), which could further help this situation with deeply nested schemas. I also verified that the two test cases here are passing, however since they essentially cover the same exact situations, it is probably best to not include these just to prevent any confusion.

The fix should be included in the next Terraform Plugin SDK release 🔜 . Thanks again for the contribution.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.