Skip to content

Latest commit

 

History

History
246 lines (178 loc) · 10.7 KB

CONTRIBUTING.md

File metadata and controls

246 lines (178 loc) · 10.7 KB
Raw

Contributing to terraform-plugin-testing

First: if you're unsure or afraid of anything, just ask or submit the issue describing the problem you're aiming to solve.

Any bug fix or feature has to be considered in the context of the wider Terraform ecosystem. This is great, as your contribution can have a big positive impact, but we have to assess potential negative impact too (e.g. breaking existing providers which may not use a new feature).

To provide some safety to the wider provider ecosystem, we strictly follow semantic versioning and any changes that we consider breaking changes will only be released as part of major releases. Note: while we're on v0, breaking changes will be accepted during minor releases.

Table of Contents

I just have a question

Note: We use GitHub for tracking bugs and feature requests related to terraform-plugin-testing.

For questions, please see relevant channels at https://www.terraform.io/community.html

I want to report a vulnerability

Please disclose security vulnerabilities responsibly by following the procedure described at https://www.hashicorp.com/security#vulnerability-reporting

New Issue

We welcome issues of all kinds, including feature requests, bug reports, or documentation contributions. Below are guidelines for well-formed issues of each type.

Bug Reports

  • Test against latest release: Make sure you test against the latest avaiable version of Terraform, terraform-plugin-go/terraform-plugin-sdk/terraform-plugin-framework, terraform-plugin-mux, and terraform-plugin-testing. It is possible we already fixed the bug you're experiencing.

  • Search for duplicates: It's helpful to keep bug reports consolidated to one thread, so do a quick search on existing bug reports to check if anybody else has reported the same thing. You can scope searches by the label bug to help narrow things down.

  • Include steps to reproduce: Provide steps to reproduce the issue, along with code examples (both HCL and Go, where applicable) and/or real code, so we can try to reproduce it. Without this, it makes it much harder (sometimes impossible) to fix the issue.

Feature Requests

  • Search for possible duplicate requests: It's helpful to keep requests consolidated to one thread, so do a quick search on existing requests to check if anybody else has requested the same thing. You can scope searches by the label enhancement to help narrow things down.

  • Include a use case description: In addition to describing the behavior of the feature you'd like to see added, it's helpful to also lay out the reason why the feature would be important and how it would benefit the wider Terraform ecosystem. A use case in the context of 1 provider is good, a use case in the context of many providers is better.

Documentation Contributions

  • Search for possible duplicate suggestions: It's helpful to keep suggestions consolidated to one thread, so do a quick search on existing issues to check if anybody else has suggested the same thing. You can scope searches by the label documentation to help narrow things down.

  • Describe the questions you're hoping the documentation will answer: It's very helpful when writing documentation to have specific questions like "how do I default a subsystem logger to off?" in mind. This helps us ensure the documentation is targeted, specific, and framed in a useful way.

  • Contribute: This repository contains the markdown files that generate versioned documentation for developer.hashicorp.com/terraform/plugin/testing/. Please open a pull request with documentation changes. Refer to the website README for more information.

New Pull Request

Thank you for contributing!

We are happy to review pull requests without associated issues, but we highly recommend starting by describing and discussing your problem or feature and attaching use cases to an issue first before raising a pull request.

  • Early validation of idea and implementation plan: terraform-plugin-testing is complicated enough that there are often several ways to implement something, each of which has different implications and tradeoffs. Working through a plan of attack with the team before you dive into implementation will help ensure that you're working in the right direction.

  • Unit Tests: It may go without saying, but every new patch should be covered by tests wherever possible.

  • Go Modules: We use Go Modules to manage and version all our dependencies. Please make sure that you reflect dependency changes in your pull requests appropriately (e.g. go get, go mod tidy or other commands). Where possible it is better to raise a separate pull request with just dependency changes as it's easier to review such PR(s).

  • Changelog: We use the Changie automation tool for changelog automation. To add a new entry to the CHANGELOG install Changie using the following instructions and run changie new then choose a kind of change corresponding to the Terraform Plugin changelog categories and then fill out the body following the entry format. Changie will then prompt for a Github issue or pull request number. Repeat this process for any additional changes. The .yaml files created in the .changes/unreleased folder should be pushed the repository along with any code changes.

  • License Headers: All source code requires a license header at the top of the file, refer to License Headers for information on how to autogenerate these headers.

Cosmetic changes, code formatting, and typos

In general we do not accept PRs containing only the following changes:

  • Correcting spelling or typos
  • Code formatting, including whitespace
  • Other cosmetic changes that do not affect functionality

While we appreciate the effort that goes into preparing PRs, there is always a tradeoff between benefit and cost. The costs involved in accepting such contributions include the time taken for thorough review, the noise created in the git history, and the increased number of GitHub notifications that maintainers must attend to.

Exceptions

We believe that one should "leave the campsite cleaner than you found it", so you are welcome to clean up cosmetic issues in the neighbourhood when submitting a patch that makes functional changes or fixes.

License Headers

All source code files (excluding autogenerated files like go.mod, prose, and files excluded in .copywrite.hcl) must have a license header at the top.

This can be autogenerated by running make generate or running go generate ./... in the /tools directory.

Linting

GitHub Actions workflow bug and style checking is performed via actionlint.

To run the GitHub Actions linters locally, install the actionlint tool, and run:

actionlint

Go code bug and style checking is performed via golangci-lint.

To run the Go linters locally, install the golangci-lint tool, and run:

golangci-lint run ./...

Testing

Code contributions should be supported by unit tests wherever possible.

GitHub Actions Tests

GitHub Actions workflow testing is performed via act.

To run the GitHub Actions testing locally (setting appropriate event):

act --artifact-server-path /tmp --env ACTIONS_RUNTIME_TOKEN=test -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest pull_request

The command options can be added to a ~/.actrc file:

--artifact-server-path /tmp
--env ACTIONS_RUNTIME_TOKEN=test
-P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest

So they do not need to be specified every invocation:

act pull_request

Go Unit Tests

Go code unit testing is perfomed via Go's built-in testing functionality.

To run the Go unit testing locally:

go test ./...

This codebase follows Go conventions for unit testing. Some guidelines include:

  • File Naming: Test files should be named *_test.go and usually reside in the same package as the code being tested.
  • Test Naming: Test functions must include the Test prefix and should be named after the function or method under test. An Example() function test should be named TestExample. A Data type Example() method test should be named TestDataExample.
  • Concurrency: Where possible, unit tests should be able to run concurrently and include a call to t.Parallel(). Usage of mutable shared data, such as environment variables or global variables that are used with reads and writes, is strongly discouraged.
  • Table Driven: Where possible, unit tests should be written using the table driven testing style.
  • go-cmp: Where possible, comparison testing should be done via go-cmp. In particular, the cmp.Diff() and cmp.Equal() functions are helpful.

A common template for implementing unit tests is:

func TestExample(t *testing.T) {
    t.Parallel()
    testCases := map[string]struct{
        // fields to store inputs and expectations
    }{
        "test-description": {
            // fields from above
        },
    }
    for name, testCase := range testCases {
        // Do not omit this next line
        name, testCase := name, testCase
        t.Run(name, func(t *testing.T) {
            t.Parallel()
            // Implement test referencing testCase fields
        })
    }
}

Maintainers Guide

This section is dedicated to the maintainers of this project.

Releases

To cut a release, go to the repository in Github and click on the Actions tab and select the Release workflow on the left-hand menu. In the Release submenu, click on the Run workflow button, select the branch to cut the release from (default is main) and input the Release version number which is the Semantic Release number including the v prefix (i.e. v1.4.0) and click Run workflow