Merge pull request #14837 from terraform-providers/acctest-ftlint-dat…

…asources Updates Terraform syntax for data source acceptance tests
hashicorp · Aug 28, 2020 · 5f7bdf7 · 5f7bdf7
2 parents a4e7ff5 + 9cf29dc
commit 5f7bdf7
Show file tree

Hide file tree

Showing 13 changed files with 78 additions and 106 deletions.
diff --git a/aws/data_source_aws_acm_certificate_test.go b/aws/data_source_aws_acm_certificate_test.go
@@ -239,7 +239,7 @@ func testAccCheckAwsAcmCertificateDataSourceConfigWithMostRecent(domain string,
 	return fmt.Sprintf(`
 data "aws_acm_certificate" "test" {
   domain      = "%s"
-  most_recent = %v
+  most_recent = %t
 }
 `, domain, mostRecent)
 }
@@ -249,7 +249,7 @@ func testAccCheckAwsAcmCertificateDataSourceConfigWithMostRecentAndStatus(domain
 data "aws_acm_certificate" "test" {
   domain      = "%s"
   statuses    = ["%s"]
-  most_recent = %v
+  most_recent = %t
 }
 `, domain, status, mostRecent)
 }
@@ -259,7 +259,7 @@ func testAccCheckAwsAcmCertificateDataSourceConfigWithMostRecentAndTypes(domain,
 data "aws_acm_certificate" "test" {
   domain      = "%s"
   types       = ["%s"]
-  most_recent = %v
+  most_recent = %t
 }
 `, domain, certType, mostRecent)
 }

diff --git a/aws/data_source_aws_cloudhsm2_cluster_test.go b/aws/data_source_aws_cloudhsm2_cluster_test.go
@@ -59,7 +59,7 @@ resource "aws_subnet" "cloudhsm_v2_test_subnets" {
 
 resource "aws_cloudhsm_v2_cluster" "cluster" {
   hsm_type   = "hsm1.medium"
-  subnet_ids = [aws_subnet.cloudhsm_v2_test_subnets.0.id, aws_subnet.cloudhsm_v2_test_subnets.1.id]
+  subnet_ids = aws_subnet.cloudhsm_v2_test_subnets[*].id
 
   tags = {
     Name = "tf-acc-aws_cloudhsm_v2_cluster-data-source-basic-%d"

diff --git a/aws/data_source_aws_elb_test.go b/aws/data_source_aws_elb_test.go
@@ -42,7 +42,7 @@ resource "aws_elb" "elb_test" {
   name            = "%[1]s"
   internal        = true
   security_groups = [aws_security_group.elb_test.id]
-  subnets         = [aws_subnet.elb_test.0.id, aws_subnet.elb_test.1.id]
+  subnets         = aws_subnet.elb_test[*].id
 
   idle_timeout = 30
 

diff --git a/aws/data_source_aws_instance_test.go b/aws/data_source_aws_instance_test.go
@@ -554,7 +554,7 @@ data "aws_instance" "test" {
 var testAccInstanceDataSourceConfig_gp2IopsDevice = testAccLatestAmazonLinuxHvmEbsAmiConfig() + `
 resource "aws_instance" "test" {
   ami           = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
-  instance_type = "m3.medium"
+  instance_type = "t3.medium"
 
   root_block_device {
     volume_type = "gp2"
@@ -571,7 +571,7 @@ data "aws_instance" "test" {
 var testAccInstanceDataSourceConfig_blockDevices = testAccLatestAmazonLinuxHvmEbsAmiConfig() + `
 resource "aws_instance" "test" {
   ami           = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
-  instance_type = "m3.medium"
+  instance_type = "t3.medium"
 
   root_block_device {
     volume_type = "gp2"
@@ -615,7 +615,7 @@ resource "aws_kms_key" "test" {
 
 resource "aws_instance" "test" {
   ami           = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
-  instance_type = "m3.medium"
+  instance_type = "t3.medium"
 
   root_block_device {
     volume_type = "gp2"
@@ -642,7 +642,7 @@ resource "aws_kms_key" "test" {
 
 resource "aws_instance" "test" {
   ami           = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
-  instance_type = "m3.medium"
+  instance_type = "t3.medium"
 
   root_block_device {
     encrypted   = true
@@ -660,7 +660,7 @@ data "aws_instance" "test" {
 var testAccInstanceDataSourceConfig_rootInstanceStore = testAccLatestAmazonLinuxHvmEbsAmiConfig() + `
 resource "aws_instance" "test" {
   ami           = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
-  instance_type = "m3.medium"
+  instance_type = "t3.medium"
 }
 
 data "aws_instance" "test" {
@@ -707,7 +707,7 @@ resource "aws_key_pair" "test" {
 
 resource "aws_instance" "test" {
   ami           = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
-  instance_type = "t1.micro"
+  instance_type = "t2.micro"
   key_name      = aws_key_pair.test.key_name
 
   tags = {
@@ -757,7 +757,7 @@ resource "aws_placement_group" "test" {
 # Limitations: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/placement-groups.html#concepts-placement-groups
 resource "aws_instance" "test" {
   ami                         = data.aws_ami.amzn-ami-minimal-hvm-ebs.id
-  instance_type               = "c3.large"
+  instance_type               = "c5.large"
   subnet_id                   = aws_subnet.test.id
   associate_public_ip_address = true
   placement_group             = aws_placement_group.test.name

diff --git a/aws/data_source_aws_instances_test.go b/aws/data_source_aws_instances_test.go
@@ -128,8 +128,8 @@ resource "aws_instance" "test" {
 
 data "aws_instances" "test" {
   instance_tags = {
-    Name      = aws_instance.test.0.tags["Name"]
-    SecondTag = aws_instance.test.1.tags["Name"]
+    Name      = aws_instance.test[0].tags["Name"]
+    SecondTag = aws_instance.test[1].tags["Name"]
   }
 }
 `, rInt, rInt)
@@ -165,7 +165,7 @@ resource "aws_instance" "test" {
 
 data "aws_instances" "test" {
   instance_tags = {
-    Name = aws_instance.test.0.tags["Name"]
+    Name = aws_instance.test[0].tags["Name"]
   }
 
   instance_state_names = ["pending", "running"]

diff --git a/aws/data_source_aws_lb_listener_test.go b/aws/data_source_aws_lb_listener_test.go
@@ -124,7 +124,7 @@ resource "aws_lb" "alb_test" {
   name            = "%s"
   internal        = true
   security_groups = [aws_security_group.alb_test.id]
-  subnets         = [aws_subnet.alb_test.0.id, aws_subnet.alb_test.1.id]
+  subnets         = aws_subnet.alb_test[*].id
 
   idle_timeout               = 30
   enable_deletion_protection = false
@@ -250,7 +250,7 @@ resource "aws_alb" "alb_test" {
   name            = "%s"
   internal        = true
   security_groups = [aws_security_group.alb_test.id]
-  subnets         = [aws_subnet.alb_test.0.id, aws_subnet.alb_test.1.id]
+  subnets         = aws_subnet.alb_test[*].id
 
   idle_timeout               = 30
   enable_deletion_protection = false
@@ -366,7 +366,7 @@ resource "aws_lb" "alb_test" {
   name            = "%[1]s"
   internal        = false
   security_groups = [aws_security_group.alb_test.id]
-  subnets         = [aws_subnet.alb_test.0.id, aws_subnet.alb_test.1.id]
+  subnets         = aws_subnet.alb_test[*].id
 
   idle_timeout               = 30
   enable_deletion_protection = false

diff --git a/aws/data_source_aws_lb_target_group_test.go b/aws/data_source_aws_lb_target_group_test.go
@@ -144,7 +144,7 @@ resource "aws_lb" "alb_test" {
   name            = "%s"
   internal        = true
   security_groups = [aws_security_group.alb_test.id]
-  subnets         = [aws_subnet.alb_test.0.id, aws_subnet.alb_test.1.id]
+  subnets         = aws_subnet.alb_test[*].id
 
   idle_timeout               = 30
   enable_deletion_protection = false
@@ -261,7 +261,7 @@ resource "aws_alb" "alb_test" {
   name            = "%s"
   internal        = true
   security_groups = [aws_security_group.alb_test.id]
-  subnets         = [aws_subnet.alb_test.0.id, aws_subnet.alb_test.1.id]
+  subnets         = aws_subnet.alb_test[*].id
 
   idle_timeout               = 30
   enable_deletion_protection = false

diff --git a/aws/data_source_aws_lb_test.go b/aws/data_source_aws_lb_test.go
@@ -114,7 +114,7 @@ resource "aws_lb" "alb_test" {
   name            = "%s"
   internal        = true
   security_groups = [aws_security_group.alb_test.id]
-  subnets         = [aws_subnet.alb_test.0.id, aws_subnet.alb_test.1.id]
+  subnets         = aws_subnet.alb_test[*].id
 
   idle_timeout               = 30
   enable_deletion_protection = false
@@ -198,7 +198,7 @@ resource "aws_alb" "alb_test" {
   name            = "%s"
   internal        = true
   security_groups = [aws_security_group.alb_test.id]
-  subnets         = [aws_subnet.alb_test.0.id, aws_subnet.alb_test.1.id]
+  subnets         = aws_subnet.alb_test[*].id
 
   idle_timeout               = 30
   enable_deletion_protection = false

diff --git a/aws/data_source_aws_mq_broker_test.go b/aws/data_source_aws_mq_broker_test.go
@@ -13,78 +13,42 @@ func TestAccDataSourceAWSMqBroker_basic(t *testing.T) {
 	prefix := "tf-acc-test-d-mq-broker"
 	brokerName := fmt.Sprintf("%s-%s", prefix, rString)
 
+	dataSourceByIdName := "data.aws_mq_broker.by_id"
+	dataSourceByNameName := "data.aws_mq_broker.by_name"
+	resourceName := "aws_mq_broker.acctest"
+
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
 			{
 				Config: testAccDataSourceAWSMqBrokerConfig_byId(brokerName, prefix),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "arn",
-						"aws_mq_broker.acctest", "arn"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "broker_name",
-						"aws_mq_broker.acctest", "broker_name"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "auto_minor_version_upgrade",
-						"aws_mq_broker.acctest", "auto_minor_version_upgrade"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "deployment_mode",
-						"aws_mq_broker.acctest", "deployment_mode"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "configuration.#",
-						"aws_mq_broker.acctest", "configuration.#"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "encryption_options.#",
-						"aws_mq_broker.acctest", "encryption_options.#"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "encryption_options.0.use_aws_owned_key",
-						"aws_mq_broker.acctest", "encryption_options.0.use_aws_owned_key"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "engine_type",
-						"aws_mq_broker.acctest", "engine_type"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "engine_version",
-						"aws_mq_broker.acctest", "engine_version"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "host_instance_type",
-						"aws_mq_broker.acctest", "host_instance_type"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "instances.#",
-						"aws_mq_broker.acctest", "instances.#"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "logs.#",
-						"aws_mq_broker.acctest", "logs.#"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "maintenance_window_start_time.#",
-						"aws_mq_broker.acctest", "maintenance_window_start_time.#"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "publicly_accessible",
-						"aws_mq_broker.acctest", "publicly_accessible"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "security_groups.#",
-						"aws_mq_broker.acctest", "security_groups.#"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "subnet_ids.#",
-						"aws_mq_broker.acctest", "subnet_ids.#"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "tags.%",
-						"aws_mq_broker.acctest", "tags.%"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_id", "user.#",
-						"aws_mq_broker.acctest", "user.#"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "arn", resourceName, "arn"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "broker_name", resourceName, "broker_name"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "auto_minor_version_upgrade", resourceName, "auto_minor_version_upgrade"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "deployment_mode", resourceName, "deployment_mode"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "configuration.#", resourceName, "configuration.#"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "encryption_options.#", resourceName, "encryption_options.#"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "encryption_options.0.use_aws_owned_key", resourceName, "encryption_options.0.use_aws_owned_key"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "engine_type", resourceName, "engine_type"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "engine_version", resourceName, "engine_version"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "host_instance_type", resourceName, "host_instance_type"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "instances.#", resourceName, "instances.#"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "logs.#", resourceName, "logs.#"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "maintenance_window_start_time.#", resourceName, "maintenance_window_start_time.#"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "publicly_accessible", resourceName, "publicly_accessible"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "security_groups.#", resourceName, "security_groups.#"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "subnet_ids.#", resourceName, "subnet_ids.#"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "tags.%", resourceName, "tags.%"),
+					resource.TestCheckResourceAttrPair(dataSourceByIdName, "user.#", resourceName, "user.#"),
 				),
 			},
 			{
 				Config: testAccDataSourceAWSMqBrokerConfig_byName(brokerName, prefix),
 				Check: resource.ComposeAggregateTestCheckFunc(
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_name", "broker_id",
-						"aws_mq_broker.acctest", "id"),
-					resource.TestCheckResourceAttrPair(
-						"data.aws_mq_broker.by_name", "broker_name",
-						"aws_mq_broker.acctest", "broker_name"),
+					resource.TestCheckResourceAttrPair(dataSourceByNameName, "broker_id", resourceName, "id"),
+					resource.TestCheckResourceAttrPair(dataSourceByNameName, "broker_name", resourceName, "broker_name"),
 				),
 			},
 		},
@@ -184,8 +148,8 @@ resource "aws_mq_broker" "acctest" {
   }
 
   publicly_accessible = true
-  security_groups     = [aws_security_group.acctest.0.id, aws_security_group.acctest.1.id]
-  subnet_ids          = [aws_subnet.acctest.0.id, aws_subnet.acctest.1.id]
+  security_groups     = aws_security_group.acctest[*].id
+  subnet_ids          = aws_subnet.acctest[*].id
 
   user {
     username = "Ender"