-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_amplify_branch #11937
Conversation
This comment has been minimized.
This comment has been minimized.
dc12f2c
to
87c15df
Compare
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplifyBranch_basic\|TestAccAWSAmplifyBranch_disappears\|TestAccAWSAmplifyBranch_Tags' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplifyBranch_basic\|TestAccAWSAmplifyBranch_disappears\|TestAccAWSAmplifyBranch_Tags -timeout 180m === RUN TestAccAWSAmplifyBranch_basic === PAUSE TestAccAWSAmplifyBranch_basic === RUN TestAccAWSAmplifyBranch_disappears === PAUSE TestAccAWSAmplifyBranch_disappears === RUN TestAccAWSAmplifyBranch_Tags === PAUSE TestAccAWSAmplifyBranch_Tags === CONT TestAccAWSAmplifyBranch_basic === CONT TestAccAWSAmplifyBranch_Tags === CONT TestAccAWSAmplifyBranch_disappears --- PASS: TestAccAWSAmplifyBranch_disappears (13.52s) --- PASS: TestAccAWSAmplifyBranch_basic (15.00s) --- PASS: TestAccAWSAmplifyBranch_Tags (30.45s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 33.761s
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn -timeout 180m === RUN TestAccAWSAmplify_serial === RUN TestAccAWSAmplify_serial/Branch === RUN TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn === PAUSE TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn === CONT TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn --- PASS: TestAccAWSAmplify_serial (28.27s) --- PASS: TestAccAWSAmplify_serial/Branch (0.00s) --- PASS: TestAccAWSAmplify_serial/Branch/BackendEnvironmentArn (28.27s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 31.532s
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/BasicAuthCredentials' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/BasicAuthCredentials -timeout 180m === RUN TestAccAWSAmplify_serial === RUN TestAccAWSAmplify_serial/Branch === RUN TestAccAWSAmplify_serial/Branch/BasicAuthCredentials === PAUSE TestAccAWSAmplify_serial/Branch/BasicAuthCredentials === CONT TestAccAWSAmplify_serial/Branch/BasicAuthCredentials --- PASS: TestAccAWSAmplify_serial (38.99s) --- PASS: TestAccAWSAmplify_serial/Branch (0.00s) --- PASS: TestAccAWSAmplify_serial/Branch/BasicAuthCredentials (38.99s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 43.099s
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/EnvironmentVariables' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/EnvironmentVariables -timeout 180m === RUN TestAccAWSAmplify_serial === RUN TestAccAWSAmplify_serial/Branch === RUN TestAccAWSAmplify_serial/Branch/EnvironmentVariables === PAUSE TestAccAWSAmplify_serial/Branch/EnvironmentVariables === CONT TestAccAWSAmplify_serial/Branch/EnvironmentVariables --- PASS: TestAccAWSAmplify_serial (35.71s) --- PASS: TestAccAWSAmplify_serial/Branch (0.00s) --- PASS: TestAccAWSAmplify_serial/Branch/EnvironmentVariables (35.71s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 38.947s
Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/OptionalArguments' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/OptionalArguments -timeout 180m === RUN TestAccAWSAmplify_serial === RUN TestAccAWSAmplify_serial/Branch === RUN TestAccAWSAmplify_serial/Branch/OptionalArguments === PAUSE TestAccAWSAmplify_serial/Branch/OptionalArguments === CONT TestAccAWSAmplify_serial/Branch/OptionalArguments --- PASS: TestAccAWSAmplify_serial (30.92s) --- PASS: TestAccAWSAmplify_serial/Branch (0.00s) --- PASS: TestAccAWSAmplify_serial/Branch/OptionalArguments (30.92s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 33.969s
…tArn' into 'testAccAWSAmplifyBranch_OptionalArguments'. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch/OptionalArguments' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch/OptionalArguments -timeout 180m === RUN TestAccAWSAmplify_serial === RUN TestAccAWSAmplify_serial/Branch === RUN TestAccAWSAmplify_serial/Branch/OptionalArguments === PAUSE TestAccAWSAmplify_serial/Branch/OptionalArguments === CONT TestAccAWSAmplify_serial/Branch/OptionalArguments --- PASS: TestAccAWSAmplify_serial (29.75s) --- PASS: TestAccAWSAmplify_serial/Branch (0.00s) --- PASS: TestAccAWSAmplify_serial/Branch/OptionalArguments (29.75s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 32.968s
…de' is 'ForceNew'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch -timeout 180m
=== RUN TestAccAWSAmplify_serial
=== RUN TestAccAWSAmplify_serial/Branch
=== RUN TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== RUN TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== RUN TestAccAWSAmplify_serial/Branch/OptionalArguments
=== PAUSE TestAccAWSAmplify_serial/Branch/OptionalArguments
=== RUN TestAccAWSAmplify_serial/Branch/basic
=== PAUSE TestAccAWSAmplify_serial/Branch/basic
=== RUN TestAccAWSAmplify_serial/Branch/disappears
=== PAUSE TestAccAWSAmplify_serial/Branch/disappears
=== RUN TestAccAWSAmplify_serial/Branch/Tags
=== PAUSE TestAccAWSAmplify_serial/Branch/Tags
=== CONT TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== CONT TestAccAWSAmplify_serial/Branch/Tags
=== CONT TestAccAWSAmplify_serial/Branch/disappears
=== CONT TestAccAWSAmplify_serial/Branch/basic
=== CONT TestAccAWSAmplify_serial/Branch/OptionalArguments
=== CONT TestAccAWSAmplify_serial/Branch/EnvironmentVariables
--- PASS: TestAccAWSAmplify_serial (43.81s)
--- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
--- PASS: TestAccAWSAmplify_serial/Branch/disappears (24.12s)
--- PASS: TestAccAWSAmplify_serial/Branch/basic (26.35s)
--- PASS: TestAccAWSAmplify_serial/Branch/OptionalArguments (35.92s)
--- PASS: TestAccAWSAmplify_serial/Branch/EnvironmentVariables (41.93s)
--- PASS: TestAccAWSAmplify_serial/Branch/BasicAuthCredentials (43.29s)
--- PASS: TestAccAWSAmplify_serial/Branch/Tags (43.81s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 47.540s
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/App'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/App -timeout 180m
=== RUN TestAccAWSAmplify_serial
=== RUN TestAccAWSAmplify_serial/App
=== RUN TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== RUN TestAccAWSAmplify_serial/App/BuildSpec
=== PAUSE TestAccAWSAmplify_serial/App/BuildSpec
=== RUN TestAccAWSAmplify_serial/App/Name
=== PAUSE TestAccAWSAmplify_serial/App/Name
=== RUN TestAccAWSAmplify_serial/App/Repository
resource_aws_amplify_app_test.go:591: Environment variable AMPLIFY_GITHUB_ACCESS_TOKEN is not set
=== RUN TestAccAWSAmplify_serial/App/disappears
=== PAUSE TestAccAWSAmplify_serial/App/disappears
=== RUN TestAccAWSAmplify_serial/App/Tags
=== PAUSE TestAccAWSAmplify_serial/App/Tags
=== RUN TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== PAUSE TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== RUN TestAccAWSAmplify_serial/App/CustomRules
=== PAUSE TestAccAWSAmplify_serial/App/CustomRules
=== RUN TestAccAWSAmplify_serial/App/Description
=== PAUSE TestAccAWSAmplify_serial/App/Description
=== RUN TestAccAWSAmplify_serial/App/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/App/EnvironmentVariables
=== RUN TestAccAWSAmplify_serial/App/IamServiceRole
=== PAUSE TestAccAWSAmplify_serial/App/IamServiceRole
=== RUN TestAccAWSAmplify_serial/App/basic
=== PAUSE TestAccAWSAmplify_serial/App/basic
=== CONT TestAccAWSAmplify_serial/App/BasicAuthCredentials
=== CONT TestAccAWSAmplify_serial/App/CustomRules
=== CONT TestAccAWSAmplify_serial/App/disappears
=== CONT TestAccAWSAmplify_serial/App/Description
=== CONT TestAccAWSAmplify_serial/App/IamServiceRole
=== CONT TestAccAWSAmplify_serial/App/EnvironmentVariables
=== CONT TestAccAWSAmplify_serial/App/basic
=== CONT TestAccAWSAmplify_serial/App/AutoBranchCreationConfig
=== CONT TestAccAWSAmplify_serial/App/Name
=== CONT TestAccAWSAmplify_serial/App/BuildSpec
=== CONT TestAccAWSAmplify_serial/App/Tags
--- PASS: TestAccAWSAmplify_serial (61.23s)
--- PASS: TestAccAWSAmplify_serial/App (0.00s)
--- SKIP: TestAccAWSAmplify_serial/App/Repository (0.00s)
--- PASS: TestAccAWSAmplify_serial/App/basic (24.02s)
--- PASS: TestAccAWSAmplify_serial/App/disappears (26.03s)
--- PASS: TestAccAWSAmplify_serial/App/Name (35.76s)
--- PASS: TestAccAWSAmplify_serial/App/BuildSpec (45.22s)
--- PASS: TestAccAWSAmplify_serial/App/Tags (45.85s)
--- PASS: TestAccAWSAmplify_serial/App/EnvironmentVariables (46.24s)
--- PASS: TestAccAWSAmplify_serial/App/CustomRules (49.56s)
--- PASS: TestAccAWSAmplify_serial/App/Description (50.08s)
--- PASS: TestAccAWSAmplify_serial/App/AutoBranchCreationConfig (59.12s)
--- PASS: TestAccAWSAmplify_serial/App/BasicAuthCredentials (60.33s)
--- PASS: TestAccAWSAmplify_serial/App/IamServiceRole (61.23s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 64.309s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAmplify_serial/Branch'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAmplify_serial/Branch -timeout 180m
=== RUN TestAccAWSAmplify_serial
=== RUN TestAccAWSAmplify_serial/Branch
=== RUN TestAccAWSAmplify_serial/Branch/OptionalArguments
=== PAUSE TestAccAWSAmplify_serial/Branch/OptionalArguments
=== RUN TestAccAWSAmplify_serial/Branch/basic
=== PAUSE TestAccAWSAmplify_serial/Branch/basic
=== RUN TestAccAWSAmplify_serial/Branch/disappears
=== PAUSE TestAccAWSAmplify_serial/Branch/disappears
=== RUN TestAccAWSAmplify_serial/Branch/Tags
=== PAUSE TestAccAWSAmplify_serial/Branch/Tags
=== RUN TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== PAUSE TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== RUN TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== PAUSE TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== CONT TestAccAWSAmplify_serial/Branch/OptionalArguments
=== CONT TestAccAWSAmplify_serial/Branch/Tags
=== CONT TestAccAWSAmplify_serial/Branch/EnvironmentVariables
=== CONT TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
=== CONT TestAccAWSAmplify_serial/Branch/disappears
=== CONT TestAccAWSAmplify_serial/Branch/basic
resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT TestAccAWSAmplify_serial/Branch/OptionalArguments
resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT TestAccAWSAmplify_serial/Branch/EnvironmentVariables
resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT TestAccAWSAmplify_serial/Branch/BasicAuthCredentials
resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT TestAccAWSAmplify_serial/Branch/disappears
resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
=== CONT TestAccAWSAmplify_serial/Branch/Tags
resource_aws_amplify_app_test.go:681: AWS Amplify is not supported in GovCloud partition
--- PASS: TestAccAWSAmplify_serial (1.44s)
--- PASS: TestAccAWSAmplify_serial/Branch (0.00s)
--- SKIP: TestAccAWSAmplify_serial/Branch/OptionalArguments (1.44s)
--- SKIP: TestAccAWSAmplify_serial/Branch/basic (1.44s)
--- SKIP: TestAccAWSAmplify_serial/Branch/EnvironmentVariables (1.44s)
--- SKIP: TestAccAWSAmplify_serial/Branch/BasicAuthCredentials (1.44s)
--- SKIP: TestAccAWSAmplify_serial/Branch/disappears (1.44s)
--- SKIP: TestAccAWSAmplify_serial/Branch/Tags (1.44s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 6.377s
This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #6917
AWS Amplify service client has been merged by #9874.
Before merging this PR, #11936 must be merged. After then, I'll run
git rebase
for this branch.Release note for CHANGELOG:
Output from acceptance testing: