Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting iops on non-provisioned IOPS EBS volumes should be a validation error #12667

Closed
gdavison opened this issue Apr 3, 2020 · 3 comments · Fixed by #14310
Closed

Setting iops on non-provisioned IOPS EBS volumes should be a validation error #12667

gdavison opened this issue Apr 3, 2020 · 3 comments · Fixed by #14310
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@gdavison
Copy link
Contributor

gdavison commented Apr 3, 2020

When creating or updating an EBS volume, either as a bare resource or as a root volume or attached volume on an EC2 instance, the code either logs a warning (root devices and creating a standalone resource) or does nothing (attached volumes or updating a standalone resource).

This should be treated as a validation error instead.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Affected Resource(s)

  • aws_instance
  • aws_ebs_volume
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Apr 3, 2020
@gdavison gdavison added this to the v3.0.0 milestone Apr 3, 2020
@gdavison gdavison added technical-debt Addresses areas of the codebase that need refactoring or redesign. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. labels Apr 3, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 3, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label May 19, 2020
@anGie44 anGie44 self-assigned this Jul 21, 2020
@anGie44
Copy link
Contributor

anGie44 commented Jul 23, 2020

The associated changes in #14310 have been merged and will release with the upcoming v3.0.0 of the Terraform AWS Provider.

@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/ec2 Issues and PRs that pertain to the ec2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
3 participants