r/cloudwatch_metric_alarm - add validations #12817

DrFaust92 · 2020-04-14T16:31:17Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_cloudwatch_metric_alarm: add plan time validations to `comparison_operator` and `statistic`, `metric_query.metric.unit`, `unit`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm_'
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (14.22s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_disappears (32.10s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (36.33s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (38.08s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (43.27s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (49.03s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (50.49s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (70.35s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (76.07s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_tags (107.46s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (168.96s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (340.33s)

ewbankkit · 2020-04-16T20:39:49Z

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchMetricAlarm_ -timeout 120m
=== RUN   TestAccAWSCloudWatchMetricAlarm_basic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_basic
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== RUN   TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== PAUSE TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== RUN   TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== RUN   TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN   TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== RUN   TestAccAWSCloudWatchMetricAlarm_expression
=== PAUSE TestAccAWSCloudWatchMetricAlarm_expression
=== RUN   TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== RUN   TestAccAWSCloudWatchMetricAlarm_tags
=== PAUSE TestAccAWSCloudWatchMetricAlarm_tags
=== RUN   TestAccAWSCloudWatchMetricAlarm_disappears
=== PAUSE TestAccAWSCloudWatchMetricAlarm_disappears
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== CONT  TestAccAWSCloudWatchMetricAlarm_disappears
=== CONT  TestAccAWSCloudWatchMetricAlarm_tags
=== CONT  TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== CONT  TestAccAWSCloudWatchMetricAlarm_expression
=== CONT  TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== CONT  TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT  TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== CONT  TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== CONT  TestAccAWSCloudWatchMetricAlarm_basic
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (11.28s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_disappears (21.22s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (24.66s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (25.74s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (28.96s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (31.30s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (32.19s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (42.42s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (42.51s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_tags (63.80s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (101.23s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (228.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	228.265s

ewbankkit · 2020-05-19T18:43:01Z

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudWatchMetricAlarm_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchMetricAlarm_ -timeout 120m
go: downloading github.com/aws/aws-sdk-go v1.31.0
go: extracting github.com/aws/aws-sdk-go v1.31.0
go: finding github.com/aws/aws-sdk-go v1.31.0
=== RUN   TestAccAWSCloudWatchMetricAlarm_basic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_basic
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== RUN   TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== PAUSE TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== RUN   TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== PAUSE TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== RUN   TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== PAUSE TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== RUN   TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== PAUSE TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== RUN   TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== RUN   TestAccAWSCloudWatchMetricAlarm_expression
=== PAUSE TestAccAWSCloudWatchMetricAlarm_expression
=== RUN   TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== PAUSE TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== RUN   TestAccAWSCloudWatchMetricAlarm_tags
=== PAUSE TestAccAWSCloudWatchMetricAlarm_tags
=== RUN   TestAccAWSCloudWatchMetricAlarm_disappears
=== PAUSE TestAccAWSCloudWatchMetricAlarm_disappears
=== CONT  TestAccAWSCloudWatchMetricAlarm_basic
=== CONT  TestAccAWSCloudWatchMetricAlarm_extendedStatistic
=== CONT  TestAccAWSCloudWatchMetricAlarm_disappears
=== CONT  TestAccAWSCloudWatchMetricAlarm_tags
=== CONT  TestAccAWSCloudWatchMetricAlarm_missingStatistic
=== CONT  TestAccAWSCloudWatchMetricAlarm_expression
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction
=== CONT  TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles
=== CONT  TestAccAWSCloudWatchMetricAlarm_treatMissingData
=== CONT  TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic
=== CONT  TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (10.93s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_disappears (21.02s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (23.25s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (24.78s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (27.06s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (29.07s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (30.23s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (40.76s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (40.92s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_tags (60.03s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (96.70s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (213.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	213.386s

remove `_strArrPtrToList` function and use set functions instead

.changelog/12817.txt

Co-authored-by: Brian Flad <bflad417@gmail.com>

bflad

Fixing up a few things before verifying again. 👍

aws/resource_aws_cloudwatch_metric_alarm.go

bflad · 2021-02-18T17:23:35Z

aws/resource_aws_cloudwatch_metric_alarm.go

 			},
 			"period": {
 				Type:          schema.TypeInt,
 				Optional:      true,
 				ConflictsWith: []string{"metric_query"},
+				ValidateFunc: validation.Any(


This one is valid 👍

aws/resource_aws_cloudwatch_metric_alarm.go

bflad

Looks good to me, thank you, @DrFaust92 🚀

References:

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (177.84s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (26.40s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (25.53s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (25.28s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (22.65s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_disappears (19.51s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (33.19s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (67.61s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (22.59s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (11.62s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_tags (47.01s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (33.18s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (199.57s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SNSTopic (23.82s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_SWFAction (23.14s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_basic (22.45s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_datapointsToAlarm (19.66s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_disappears (16.42s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (33.05s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_expression (78.23s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_extendedStatistic (18.22s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_missingStatistic (8.10s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_tags (48.94s)
--- PASS: TestAccAWSCloudWatchMetricAlarm_treatMissingData (33.07s)

ghost · 2021-02-19T16:56:25Z

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-03-21T17:10:49Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

DrFaust92 requested a review from a team April 14, 2020 16:31

DrFaust92 force-pushed the r/cloudwatch_metric_alarm_refactor branch from 3c4c577 to 960f02d Compare May 19, 2020 16:32

DrFaust92 force-pushed the r/cloudwatch_metric_alarm_refactor branch from bc24a75 to 6cba084 Compare May 22, 2020 15:49

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:27

DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 4, 2020

DrFaust92 force-pushed the r/cloudwatch_metric_alarm_refactor branch from 6cba084 to fe2feec Compare September 4, 2020 10:58

Base automatically changed from master to main January 23, 2021 00:57

breathingdust requested a review from a team as a code owner January 23, 2021 00:57

DrFaust92 added 5 commits February 11, 2021 20:15

add plan time validation to comparison_operator, statistic

4c4ed65

remove `_strArrPtrToList` function and use set functions instead

fmt

a616cb9

add disappearing test case

50877e4

disappears

fc4bda7

add validations

469c142

DrFaust92 force-pushed the r/cloudwatch_metric_alarm_refactor branch from 0578850 to 469c142 Compare February 11, 2021 18:17

DrFaust92 added 2 commits February 11, 2021 20:43

validations

63c56ca

fix validations

d9c2f09

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 11, 2021

changelog

0b50a08

bflad reviewed Feb 16, 2021

View reviewed changes

.changelog/12817.txt Outdated Show resolved Hide resolved

Update .changelog/12817.txt

5417d58

Co-authored-by: Brian Flad <bflad417@gmail.com>

bflad self-assigned this Feb 18, 2021

bflad reviewed Feb 18, 2021

View reviewed changes

aws/resource_aws_cloudwatch_metric_alarm.go Outdated Show resolved Hide resolved

bflad reviewed Feb 18, 2021

View reviewed changes

aws/resource_aws_cloudwatch_metric_alarm.go Outdated Show resolved Hide resolved

Apply suggestions from code review

b3faa5d

bflad approved these changes Feb 18, 2021

View reviewed changes

bflad merged commit bf4f55c into hashicorp:main Feb 18, 2021

github-actions bot added this to the v3.29.0 milestone Feb 18, 2021

ghost locked as resolved and limited conversation to collaborators Mar 21, 2021

DrFaust92 deleted the r/cloudwatch_metric_alarm_refactor branch April 15, 2021 10:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/cloudwatch_metric_alarm - add validations #12817

r/cloudwatch_metric_alarm - add validations #12817

DrFaust92 commented Apr 14, 2020 •

edited

Loading

ewbankkit commented Apr 16, 2020

ewbankkit commented May 19, 2020

bflad left a comment

bflad Feb 18, 2021

bflad left a comment

ghost commented Feb 19, 2021

ghost commented Mar 21, 2021

r/cloudwatch_metric_alarm - add validations #12817

r/cloudwatch_metric_alarm - add validations #12817

Conversation

DrFaust92 commented Apr 14, 2020 • edited Loading

Community Note

ewbankkit commented Apr 16, 2020

ewbankkit commented May 19, 2020

bflad left a comment

Choose a reason for hiding this comment

bflad Feb 18, 2021

Choose a reason for hiding this comment

bflad left a comment

Choose a reason for hiding this comment

ghost commented Feb 19, 2021

ghost commented Mar 21, 2021

DrFaust92 commented Apr 14, 2020 •

edited

Loading