Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access-properties to aws_workspaces_directory #12866

Closed
heldersepu opened this issue Apr 16, 2020 · 3 comments · Fixed by #16688
Closed

Add access-properties to aws_workspaces_directory #12866

heldersepu opened this issue Apr 16, 2020 · 3 comments · Fixed by #16688
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/workspaces Issues and PRs that pertain to the workspaces service.
Milestone

Comments

@heldersepu
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a +1 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

One of the options on Amazon Workspaces directory is the device types.
Screenshot from 2020-04-16 16-06-18

New or Affected Resource(s)

  • aws_workspaces_directory

Potential Terraform Configuration

resource "aws_workspaces_directory" "example" {
  directory_id = aws_directory_service_directory.example.id

  access_properties {
    device_type_windows = true
    device_type_osx = true
    device_type_web = true
    device_type_ios = true
    device_type_android = true
    device_type_chromeos = true
    device_type_zeroclien = true
  }
}

References

@heldersepu heldersepu added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 16, 2020
@ghost ghost added the service/workspaces Issues and PRs that pertain to the workspaces service. label Apr 16, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 16, 2020
@lmorfitt
Copy link

Until this is merged it is possible to set the settings with the following


data "aws_region" "current" {}

resource "null_resource" "modify-workspace-access-properties" {
  provisioner "local-exec" {

    # Invoke the AWS CLI passing through the required JSON body to setup the client actions
    # https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/workspaces.html#WorkSpaces.Client.modify_workspace_access_properties
    # Tested with AWS Cli version `aws-cli/2.0.40 Python/3.7.4 Darwin/19.6.0 exe/x86_64`
    command = <<-EOT
      aws workspaces modify-workspace-access-properties \
        --region=${data.aws_region.current.name} \
        --resource-id=${aws_workspaces_directory.this.id} \
        --workspace-access-properties='
         {
          "DeviceTypeWindows": "ALLOW",
          "DeviceTypeOsx": "ALLOW",
          "DeviceTypeWeb": "ALLOW",
          "DeviceTypeIos": "ALLOW",
          "DeviceTypeAndroid": "ALLOW",
          "DeviceTypeChromeOs": "ALLOW",
          "DeviceTypeZeroClient": "ALLOW"
        }'
    EOT
  }
}

@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 13, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/workspaces Issues and PRs that pertain to the workspaces service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants