Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_workspaces_directory #13529

Merged
merged 4 commits into from
Jul 14, 2020
Merged

New Data Source: aws_workspaces_directory #13529

merged 4 commits into from
Jul 14, 2020

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented May 28, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

New Data Source: aws_workspaces_directory (#13529)

Example

data "aws_workspaces_directory" "example" {
  directory_id = "d-9067783251"
}

Acceptance Tests

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsWorkspacesDirectory_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWorkspacesDirectory_basic -timeout 120m
=== RUN   TestAccDataSourceAwsWorkspacesDirectory_basic
=== PAUSE TestAccDataSourceAwsWorkspacesDirectory_basic
=== CONT  TestAccDataSourceAwsWorkspacesDirectory_basic
--- PASS: TestAccDataSourceAwsWorkspacesDirectory_basic (638.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	645.726s

References

@Tensho Tensho requested a review from a team May 28, 2020 09:02
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 28, 2020
@gdavison gdavison self-assigned this Jun 3, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Jun 4, 2020
gdavison
gdavison requested changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Tensho. A few comments

website/docs/d/workspaces_bundle.html.markdown Outdated Show resolved Hide resolved
aws/data_source_aws_workspaces_directory_test.go Show resolved Hide resolved
aws/data_source_aws_workspaces_directory.go Show resolved Hide resolved
@Tensho Tensho force-pushed the d-workspaces-directory branch from 8de3f66 to 21003fa Compare June 5, 2020 09:17
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jun 5, 2020
@Tensho
Copy link
Contributor Author

Tensho commented Jun 5, 2020

@gdavison Fixes are applied, please review it again 🙇

gdavison
gdavison reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing with

--- FAIL: TestAccDataSourceAwsWorkspacesDirectory_basic (270.14s)
testing.go:684: Step 0 error: errors during apply:
Error: error getting WorkSpaces Directory (): ValidationException: The request is invalid.
  status code: 400, request id: f4d5374e-b83e-4b45-9a38-954295c2b6ed

It looks like the directory_id is not set

aws/data_source_aws_workspaces_directory_test.go Outdated Show resolved Hide resolved
@gdavison gdavison added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 18, 2020
@Tensho Tensho force-pushed the d-workspaces-directory branch from 21003fa to 2a24c91 Compare June 24, 2020 12:39
@Tensho
Copy link
Contributor Author

Tensho commented Jun 24, 2020

@gdavison Fixed

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 24, 2020
@Tensho Tensho force-pushed the d-workspaces-directory branch from 2a24c91 to 1beca9d Compare July 9, 2020 12:36
gdavison
gdavison approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccDataSourceAwsWorkspaceBundle_bundleIDAndNameConflict (1.41s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_basic (9.08s)
--- PASS: TestAccDataSourceAwsWorkspaceBundle_byOwnerName (9.50s)
--- PASS: TestAccDataSourceAwsWorkspacesDirectory_basic (602.32s)

@gdavison gdavison added this to the v3.0.0 milestone Jul 13, 2020
@gdavison gdavison merged commit 9761af5 into hashicorp:master Jul 14, 2020
gdavison added a commit that referenced this pull request Jul 14, 2020
@gdavison
Update CHANGELOG for #13529
66b3da4
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/workspaces Issues and PRs that pertain to the workspaces service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tensho @gdavison