Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_msk_cluster: support in-place Kafka version upgrade #13654

Merged
merged 1 commit into from
Nov 17, 2020
Merged

aws_msk_cluster: support in-place Kafka version upgrade #13654

merged 1 commit into from
Nov 17, 2020

Conversation

arafsheikh
Copy link
Contributor

@arafsheikh arafsheikh commented Jun 7, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13547

Release note for CHANGELOG:

resource/aws_msk_cluster: support in-place Kafka version upgrade [GH-13547]

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSMskCluster_KafkaVersionUpgrade'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskCluster_KafkaVersionUpgrade -timeout 120m
=== RUN   TestAccAWSMskCluster_KafkaVersionUpgrade
=== PAUSE TestAccAWSMskCluster_KafkaVersionUpgrade
=== CONT  TestAccAWSMskCluster_KafkaVersionUpgrade
--- PASS: TestAccAWSMskCluster_KafkaVersionUpgrade (4734.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4736.762s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSMskCluster_KafkaVersionUpgradeWithConfigurationInfo'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskCluster_KafkaVersionUpgradeWithConfigurationInfo -timeout 120m
=== RUN   TestAccAWSMskCluster_KafkaVersionUpgradeWithConfigurationInfo
=== PAUSE TestAccAWSMskCluster_KafkaVersionUpgradeWithConfigurationInfo
=== CONT  TestAccAWSMskCluster_KafkaVersionUpgradeWithConfigurationInfo
--- PASS: TestAccAWSMskCluster_KafkaVersionUpgradeWithConfigurationInfo (6143.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	6145.800s
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSMskCluster_KafkaVersionDowngrade'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMskCluster_KafkaVersionDowngrade -timeout 120m
=== RUN   TestAccAWSMskCluster_KafkaVersionDowngrade
=== PAUSE TestAccAWSMskCluster_KafkaVersionDowngrade
=== CONT  TestAccAWSMskCluster_KafkaVersionDowngrade
--- PASS: TestAccAWSMskCluster_KafkaVersionDowngrade (3230.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3232.396s

@arafsheikh arafsheikh requested a review from a team June 7, 2020 16:31
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/kafka Issues and PRs that pertain to the kafka service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. dependencies Used to indicate dependency changes. labels Jun 7, 2020
@arafsheikh arafsheikh mentioned this pull request Jun 7, 2020
Closed
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Jun 8, 2020
@arafsheikh arafsheikh force-pushed the master branch 2 times, most recently from ca596f9 to 054352d Compare June 12, 2020 19:40
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed dependencies Used to indicate dependency changes. needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2020
@silvestriluca
Copy link

Hello.

Is there an ETA on this PR ? It's stale from quite few days and it's a very useful addition for MSK users.

@cdenneen
Copy link

Need to perform in-place upgrade and the feature has been implemented almost a year ago now. Can this PR be merged?

@aheuermann
Copy link

aheuermann commented Sep 11, 2020 •
edited
Loading

Could someone please take a look at this PR? Would love to be able to do rolling kafka upgrades. Right now it requires a full replacement.

@arafsheikh
Copy link
Contributor Author

Hi @bflad, this would be a valuable feature for a lot of us. Happy to discuss any concerns with the current solution.

bill-rich
bill-rich suggested changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great overall. Thank you for taking the time to write this. I had one question/request about downgrading, and one for test coverage.

aws/resource_aws_msk_cluster.go Outdated Show resolved Hide resolved
aws/resource_aws_msk_cluster_test.go Outdated Show resolved Hide resolved
@arafsheikh arafsheikh requested a review from a team as a code owner November 4, 2020 20:30
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 4, 2020
@bill-rich bill-rich self-assigned this Nov 5, 2020
@anGie44 anGie44 self-assigned this Nov 12, 2020
@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 13, 2020
@anGie44 anGie44 removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 17, 2020
@anGie44 anGie44 added this to the v3.16.0 milestone Nov 17, 2020
anGie44
anGie44 approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @arafsheikh!

output of acceptance tests (passing minus known failure tracked in #16249):

--- PASS: TestAccAWSMskCluster_basic (1596.80s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionAtRestKmsKeyArn (1599.19s)
--- PASS: TestAccAWSMskClusterDataSource_Name (1603.31s)
--- PASS: TestAccAWSMskCluster_EnhancedMonitoring (1682.11s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_InCluster (1724.10s)
--- PASS: TestAccAWSMskCluster_EncryptionInfo_EncryptionInTransit_ClientBroker (1724.86s)
--- PASS: TestAccAWSMskCluster_Tags (1755.12s)
--- PASS: TestAccAWSMskCluster_OpenMonitoring (1902.44s)
--- PASS: TestAccAWSMskCluster_BrokerNodeGroupInfo_EbsVolumeSize (1981.06s)
--- PASS: TestAccAWSMskCluster_NumberOfBrokerNodes (2274.10s)
--- PASS: TestAccAWSMskCluster_ConfigurationInfo_Revision (2377.73s)
--- PASS: TestAccAWSMskCluster_KafkaVersionDowngrade (3449.64s)
--- PASS: TestAccAWSMskCluster_KafkaVersionUpgrade (5527.38s)
--- PASS: TestAccAWSMskCluster_KafkaVersionUpgradeWithConfigurationInfo (5535.80s)
--- FAIL: TestAccAWSMskCluster_LoggingInfo (1702.11s) -- ongoing test failure

@anGie44 anGie44 merged commit a1ea7ce into hashicorp:master Nov 17, 2020
anGie44 added a commit that referenced this pull request Nov 17, 2020
@anGie44
Update CHANGELOG for #13654
ddc3901
@ghost
Copy link

ghost commented Nov 18, 2020

This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jon-ruckwood jon-ruckwood jon-ruckwood left review comments

@cemeyer2 cemeyer2 cemeyer2 left review comments

@anGie44 anGie44 anGie44 approved these changes

@bill-rich bill-rich Awaiting requested review from bill-rich

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.16.0
Development

Successfully merging this pull request may close these issues.

aws_msk_cluster support in-place upgrades
9 participants
@arafsheikh @silvestriluca @cdenneen @aheuermann @cemeyer2 @jon-ruckwood @bill-rich @anGie44 @bflad