Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add awsproviderlint check to prefer RFC 3339 dates #13708

Closed
gdavison opened this issue Jun 10, 2020 · 2 comments
Closed

Add awsproviderlint check to prefer RFC 3339 dates #13708

gdavison opened this issue Jun 10, 2020 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. linter Pertains to changes to or issues with the various linters. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@gdavison
Copy link
Contributor

gdavison commented Jun 10, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add a check for RFC 3339 date formatting in attribute values

Flagged Provider Code

var createdDate time.Time
...
d.Set("created_date", createdDate.String())
var createdDate time.Time
...
d.Set("created_date", Format(time.ANSIC))

Passing Provider Code

var createdDate time.Time
...
d.Set("created_date", createdDate.Format(time.RFC3339))
@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 10, 2020
@bflad bflad added the linter Pertains to changes to or issues with the various linters. label Dec 15, 2020
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Dec 5, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. linter Pertains to changes to or issues with the various linters. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

2 participants