Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Support arbitrary additional tag data, implement keyvaluetags and ignore_tags support in aws_autoscaling_group resource, return empty strings with key-only tags instead of panicking #13868

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 22, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12368
Closes #12701
Closes #13808
Closes #14768

Release note for CHANGELOG:

* resource/aws_autoscaling_group: Support provider-level `ignore_tags` configuration
* resource/aws_lightsail_instance: Prevent panic with key-only tags

Output from acceptance testing:

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (270.49s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (347.98s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (48.39s)
--- PASS: TestAccAWSAutoScalingGroup_basic (240.73s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (57.40s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (301.11s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (203.91s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (262.41s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (80.07s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (100.28s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (141.65s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (80.33s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (835.18s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (108.58s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (54.75s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (83.27s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (86.71s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (84.96s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (47.10s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (89.58s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (85.66s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (75.63s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (48.09s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (87.27s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (90.33s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (177.12s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (77.41s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (43.51s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (210.03s)
--- PASS: TestAccAWSAutoScalingGroup_tags (228.44s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (243.95s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (173.57s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (81.11s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (315.22s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (316.01s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (115.03s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (232.21s)

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 22, 2020
@bflad bflad requested a review from a team June 22, 2020 14:40
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 22, 2020
@ewbankkit
Copy link
Contributor

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Jun 25, 2020
@bflad bflad force-pushed the f-keyvaluetags-autoscaling branch from 91f02a9 to a22c22b Compare July 6, 2020 19:27
@bflad
Copy link
Contributor Author

bflad commented Jul 6, 2020

Rebased and re-verified:

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (175.59s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (307.41s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (53.58s)
--- PASS: TestAccAWSAutoScalingGroup_basic (271.50s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (81.34s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (63.89s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (158.10s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (272.15s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (51.46s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (59.35s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (172.15s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (53.72s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (556.01s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (97.18s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (84.80s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (84.68s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (142.47s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (110.84s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (57.34s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (84.39s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (147.12s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (89.85s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (48.93s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (83.02s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (146.64s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (169.50s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (91.83s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (81.65s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (235.15s)
--- PASS: TestAccAWSAutoScalingGroup_tags (244.95s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (239.74s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (141.07s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (174.64s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (388.90s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (361.88s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (78.39s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (182.13s)

@bflad
Copy link
Contributor Author

bflad commented Aug 20, 2020

Rebased and re-verified:

--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (179.86s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (333.20s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (51.77s)
--- PASS: TestAccAWSAutoScalingGroup_basic (240.41s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (134.91s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (177.09s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (243.57s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (45.88s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (58.72s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (106.61s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (51.25s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (618.13s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (165.12s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (44.59s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (42.10s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (76.16s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (47.32s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (43.62s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (82.44s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (150.94s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (78.70s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (45.47s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (84.44s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (76.53s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (207.67s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (50.25s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (54.73s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (198.11s)
--- PASS: TestAccAWSAutoScalingGroup_tags (232.54s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (247.63s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (105.39s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (175.27s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (251.24s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (392.43s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (81.00s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (146.95s)

@@ -133,25 +134,27 @@ func isResourceTimeoutError(err error) bool {
// {{ . | Title }}CreateTags creates {{ . }} service tags for new resources.
Copy link
Contributor

@ewbankkit ewbankkit Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isAWSErrCode() and isAWSErrCodeContains() above can also be removed now and replaced by functions in github.com/hashicorp/aws-sdk-go-base/tfawserr.

I have a similar internal package github.com/terraform-providers/terraform-provider-aws/aws/internal/resourceerr in #13036.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice yeah. Thanks for the reminder on that -- could you ensure there's a covering GitHub issue for this. I'll save that general refactoring for after this change, since this is already too big. 😭

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, now reading #13036 I see this is already a part of that. We'll take a look after this gets in.

@ewbankkit
Copy link
Contributor

Is there an opportunity to address #11480 with this one, modifying internal/keyvaluetags/generators/updatetags/main.go, changing updatedTags := oldTags.Updated(newTags) to updatedTags := oldTags.Updated(newTags).IgnoreAws() (and the same for removedTags)?

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! I second @ewbankkit 's comment to see if the issue re: the special aws: prefixed tags could be easily addressed with these changes, otherwise as-is (aside from the 1 emerging merge conflict) LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccAWSAutoScalingGroup_namePrefix (45.59s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (64.69s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (69.06s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (104.27s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (110.31s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (113.28s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (117.27s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (70.47s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (154.61s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (118.49s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (178.23s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (183.23s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (81.79s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (52.13s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (201.28s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (55.28s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (210.29s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (110.69s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (105.23s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (224.75s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (40.96s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (122.30s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (238.03s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (75.54s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (58.45s)
--- PASS: TestAccAWSAutoScalingGroup_tags (248.04s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (38.50s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (261.58s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (100.01s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (100.70s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (294.04s)
--- PASS: TestAccAWSAutoScalingGroup_basic (301.35s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (140.95s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (404.02s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (447.12s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (583.19s)

…on, fix nil value panics, implement autoscaling service tags

Reference: #12368
Reference: #13808
…ovider ignore_tags

Reference: #13808

Output from acceptance testing:

```
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (179.86s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (333.20s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (51.77s)
--- PASS: TestAccAWSAutoScalingGroup_basic (240.41s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (134.91s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (177.09s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (243.57s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (45.88s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (58.72s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (106.61s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (51.25s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (618.13s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (165.12s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (44.59s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (42.10s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (76.16s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (47.32s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (43.62s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (82.44s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (150.94s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (78.70s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (45.47s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (84.44s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (76.53s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (207.67s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (50.25s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (54.73s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (198.11s)
--- PASS: TestAccAWSAutoScalingGroup_tags (232.54s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (247.63s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (105.39s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (175.27s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (251.24s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (392.43s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (81.00s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (146.95s)
```
@bflad
Copy link
Contributor Author

bflad commented Sep 1, 2020

The changes necessary for #11480 are not related to the intentions of this pull request, but a followup can certainly be submitted with covering acceptance test(s). 👍

@bflad bflad added this to the v3.5.0 milestone Sep 1, 2020
@bflad bflad merged commit e446592 into master Sep 1, 2020
@bflad bflad deleted the f-keyvaluetags-autoscaling branch September 1, 2020 00:59
bflad added a commit that referenced this pull request Sep 1, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants