Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/directory_service_directory: return error if 0 results found #14006

Merged
merged 1 commit into from
Jul 14, 2020
Merged

data-source/directory_service_directory: return error if 0 results found #14006

merged 1 commit into from
Jul 14, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jul 1, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13410

Release note for CHANGELOG:

data-source/directory_service_directory: return error if 0 results found

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent (2.66s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (589.73s)
--- PASS: TestAccDataSourceAWSDirectoryServiceDirectory_connector (1060.38s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1796.38s)

@anGie44 anGie44 requested a review from a team July 1, 2020 03:42
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/directoryservice tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 1, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 1, 2020
@bflad bflad self-assigned this Jul 1, 2020
bflad
bflad approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent (2.56s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (584.52s)
--- PASS: TestAccDataSourceAWSDirectoryServiceDirectory_connector (1049.05s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1804.77s)

aws/data_source_aws_directory_service_directory_test.go Outdated Show resolved Hide resolved
@anGie44 anGie44 closed this Jul 1, 2020
@anGie44 anGie44 force-pushed the td-singular-data-sources branch from 7f45422 to f354e8b Compare July 1, 2020 16:14
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 1, 2020
@anGie44 anGie44 reopened this Jul 1, 2020
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 1, 2020
@anGie44
Copy link
Contributor Author

anGie44 commented Jul 14, 2020 •
edited
Loading

Reconfirmed test output after harcoded ID change for NonExistent test:

--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_NonExistent (2.21s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (586.60s)
--- PASS: TestAccDataSourceAWSDirectoryServiceDirectory_connector (1061.81s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1726.55s)

@anGie44 anGie44 merged commit dc334c0 into master Jul 14, 2020
@anGie44 anGie44 deleted the td-singular-data-sources branch July 14, 2020 18:08
anGie44 added a commit that referenced this pull request Jul 14, 2020
@anGie44
Update CHANGELOG for #14006
2013d2b
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @bflad