Fix suppressEquivalentSnsTopicSubscriptionDeliveryPolicy

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #14041

Release note for CHANGELOG:

resource/aws_sns_topic_subscription: Ensure `delivery_policy` is compared properly during plans (https://github.com/terraform-providers/terraform-provider-aws/pull/14255)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestSuppressEquivalentSnsTopicSubscriptionDeliveryPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestSuppressEquivalentSnsTopicSubscriptionDeliveryPolicy -timeout 120m
=== RUN   TestSuppressEquivalentSnsTopicSubscriptionDeliveryPolicy
--- PASS: TestSuppressEquivalentSnsTopicSubscriptionDeliveryPolicy (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1.639s
...

suppressEquivalentSnsTopicSubscriptionDeliveryPolicy method compared a normalized delivery_policy with a "raw" delivery_policy and check if diffs existed. As a result, unnecessary diffs showed up. So I fixed the method so that it always compare a normalized new delivery_policy with a normalized old delivery_policy.

[YakDriver]

Looks great! 🎉

Acceptance tests of GovCloud:

--- PASS: TestSuppressEquivalentSnsTopicSubscriptionDeliveryPolicy (0.00s)

--- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (1.26s)
--- SKIP: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (1.26s)
--- PASS: TestAccAWSSNSTopicSubscription_email (18.89s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (22.52s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (48.40s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (48.88s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (49.94s)
--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (52.86s)
--- SKIP: TestAccAWSSNSTopicSubscription_firehose (58.42s)

On us-west-2:

--- PASS: TestSuppressEquivalentSnsTopicSubscriptionDeliveryPolicy (0.00s)

--- PASS: TestAccAWSSNSTopicSubscription_email (15.61s)
--- PASS: TestAccAWSSNSTopicSubscription_basic (18.41s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (37.36s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (37.91s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (38.22s)
--- PASS: TestAccAWSSNSTopicSubscription_redrivePolicy (41.30s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (55.72s)
--- PASS: TestAccAWSSNSTopicSubscription_firehose (79.92s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (88.39s)

[ghost]

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!