Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cloud_watch_logs resource appends wildcard to ARN in output #14410

Closed
GoldFlsh opened this issue Jul 30, 2020 · 4 comments
Closed

aws_cloud_watch_logs resource appends wildcard to ARN in output #14410

GoldFlsh opened this issue Jul 30, 2020 · 4 comments
Labels
service/cloudwatch Issues and PRs that pertain to the cloudwatch service.
Milestone

Comments

@GoldFlsh
Copy link

GoldFlsh commented Jul 30, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.12.24

  • provider.archive v1.3.0
  • provider.aws v2.69.0

Affected Resource(s)

  • resource: aws_cloudwatch_log_group
  • data: aws_cloudwatch_log_group

Terraform Configuration Files

resource "aws_cloudwatch_log_group" "log-group" {
  name = "my-log-group"
}

data "aws_cloudwatch_log_group" "log-group" {
  name = "my-log-group"
}

output "log-group-arn-resource" {
  value = aws_cloudwatch_log_group.log-group.arn
}

output "log-group-arn-data" {
  value = data.aws_cloudwatch_log_group.log-group.arn
}

Debug Output

Panic Output

Expected Behavior

Expect output to be:
arn:aws:logs:{region}:xxxxxxxxxxxx:log-group:my-log-group

Actual Behavior

arn:aws:logs:{region}:xxxxxxxxxxxx:log-group:my-log-group:*

Steps to Reproduce

  1. terraform apply

Important Factoids

I would expect it to leave off the :* so it can be used in other resources, if a :* is needed for something, then the dev can know to add it instead of having to strip it off when it's in the way.

For example, I am trying to use it in an IAM role where :* is not the appropriate format.
https://docs.amazonaws.cn/en_us/IAM/latest/UserGuide/list_amazoncloudwatchlogs.html

arn:${Partition}:logs:${Region}:${Account}:log-group:${LogGroupName}
arn:${Partition}:logs:${Region}:${Account}:log-group:${LogGroupName}:log-stream:${LogStreamName}

To ensure the fix is backwards compatible, adding a new output with the strict arn would work.

References

  • #0000
@ghost ghost added service/cloudwatchlogs service/cloudwatch Issues and PRs that pertain to the cloudwatch service. labels Jul 30, 2020
@GoldFlsh GoldFlsh changed the title aws_cloud_watch_logs resource appends :* to ARN in output aws_cloud_watch_logs resource appends wildcard to ARN in output Jul 30, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 30, 2020
@bflad
Copy link
Contributor

bflad commented Jul 30, 2020

Hi @GoldFlsh 👋 Thank you for submitting this and its indeed frustrating behavior. Prior versions of the Terraform AWS Provider just passthrough the ARN value from the CloudWatch Logs API, which includes the :*. Version 3 of the Terraform AWS Provider will automatically trim this suffix from the API response. Please see the following for further tracking of this change, which should be happening shortly:

@bflad bflad closed this as completed Jul 30, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 30, 2020
@GoldFlsh
Copy link
Author

Great to hear, thank you for fixing this @bflad !

@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 29, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudwatch Issues and PRs that pertain to the cloudwatch service.
Projects
None yet
Development

No branches or pull requests

3 participants