-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on lambda updates, output the returned values to ensure consistency #14578
on lambda updates, output the returned values to ensure consistency #14578
Conversation
This fixes #13099 too! |
is there any timeline for this getting merged? auto lambda versioning is broken without this |
This would be a helpful fix! |
@keithcom Thank you for your work on this PR! I will be working on this before long. In order to expedite the process, I will likely make some changes. Make sure that you have checked the box "Allow edits from maintainers." (Don't worry though, you will receive all credit for your contribution and code!) Also, please coordinate with us before making any commits to this branch. Again, thank you for your help and we look forward to this popular addition to the AWS provider! |
fee7899
to
b64f075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
GovCloud:
--- PASS: TestAccAWSLambdaFunction_versioned (45.55s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (76.22s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (77.48s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (96.20s)
--- PASS: TestAccAWSLambdaAlias_basic (43.96s)
--- PASS: TestAccAWSLambdaAlias_FunctionName_Name (54.76s)
--- PASS: TestAccAWSLambdaAlias_nameupdate (62.34s)
--- PASS: TestAccAWSLambdaAlias_routingconfig (70.64s)
us-west-2
:
--- PASS: TestAccAWSLambdaFunction_versioned (50.41s)
--- PASS: TestAccAWSLambdaFunction_disablePublish (80.97s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (89.92s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (90.78s)
--- PASS: TestAccAWSLambdaAlias_nameupdate (40.70s)
--- PASS: TestAccAWSLambdaAlias_FunctionName_Name (43.94s)
--- PASS: TestAccAWSLambdaAlias_basic (44.22s)
--- PASS: TestAccAWSLambdaAlias_routingconfig (74.77s)
This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
On lambda updates that publish new versions, output the returned values to ensure consistency as the read is eventually consistent.
Community Note
Closes #14210
Closes #13099
Release note for CHANGELOG:
Output from acceptance testing: