Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Route53 CAA records #1465

Closed
arkadiyt opened this issue Aug 22, 2017 · 6 comments
Closed

Support for Route53 CAA records #1465

arkadiyt opened this issue Aug 22, 2017 · 6 comments

Comments

@arkadiyt
Copy link

Amazon has announced route53 support for certificate authority authorization (CAA) records:
https://forums.aws.amazon.com/ann.jspa?annID=4799

This issue is a feature request to add support for this record type.

Terraform Version

$ terraform -v
Terraform v0.10.2

Affected Resource(s)

  • aws_route53_record

Terraform Configuration Files

resource "aws_route53_record" "example-com-caa" {
  zone_id = "${aws_route53_zone.example-com.zone_id}"
  name    = "example.com"
  type    = "CAA"
  ttl     = 300

  records = [
    "0 issue \"letsencrypt.org\"",
    "0 iodef \"mailto:caa@example.com\"",
  ]
}

Debug Output

https://gist.github.com/arkadiyt/5b75f26fa1ec71ba847202de5d4970bc

Panic Output

N/A

Expected Behavior

Should have created a CAA record

Actual Behavior

Threw an exception

Steps to Reproduce

terraform plan or terraform apply

Important Factoids

N/A

References

N/A

@gazoakley
Copy link
Contributor

There's a validator in Terraform that checks the record type is one of a supported list:

https://github.com/terraform-providers/terraform-provider-aws/blob/ab0919122d08bf94fa1d4128da801a429827ed05/aws/validators.go#L802

@Ninir
Copy link
Contributor

Ninir commented Aug 23, 2017

This has just been merged. Thanks again @gazoakley :)

@Ninir Ninir closed this as completed Aug 23, 2017
@arkadiyt
Copy link
Author

Thank you!

@gazoakley
Copy link
Contributor

@Ninir Thanks for getting it reviewed quick 👍

@bflad
Copy link
Contributor

bflad commented Aug 23, 2017

Thanks for getting this in so quick!

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants