-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/iot_authorizer - new resource #14671
Conversation
Notification of Recent and Upcoming Changes to ContributionsThank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization. If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items. For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported. Action Required: Terraform 0.12 SyntaxReference: #8950 Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations ( Action Required: Terraform Plugin SDK Version 2Reference: #14551 The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information. Action Required: Removal of website/aws.erb FileReference: #14712 Any changes to the Upcoming Change of Git Branch NamingReference: #14292 Development environments will need their upstream Git branch updated from Upcoming Change of GitHub OrganizationReference: #14715 This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including |
b5cbaf0
to
aa63a89
Compare
@bflad any timescales on review of this? quite a lot of +1’s now |
@bflad anyone looking at this? |
…' are only required if signing is enabled.
082223b
to
8004165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSIoTAuthorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTAuthorizer_ -timeout 180m
=== RUN TestAccAWSIoTAuthorizer_basic
=== PAUSE TestAccAWSIoTAuthorizer_basic
=== RUN TestAccAWSIoTAuthorizer_disappears
=== PAUSE TestAccAWSIoTAuthorizer_disappears
=== RUN TestAccAWSIoTAuthorizer_SigningDisabled
=== PAUSE TestAccAWSIoTAuthorizer_SigningDisabled
=== RUN TestAccAWSIoTAuthorizer_Update
=== PAUSE TestAccAWSIoTAuthorizer_Update
=== CONT TestAccAWSIoTAuthorizer_basic
=== CONT TestAccAWSIoTAuthorizer_Update
=== CONT TestAccAWSIoTAuthorizer_SigningDisabled
=== CONT TestAccAWSIoTAuthorizer_disappears
--- PASS: TestAccAWSIoTAuthorizer_disappears (40.49s)
--- PASS: TestAccAWSIoTAuthorizer_Update (45.84s)
--- PASS: TestAccAWSIoTAuthorizer_basic (49.35s)
--- PASS: TestAccAWSIoTAuthorizer_SigningDisabled (54.32s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 57.722s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSIoTAuthorizer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTAuthorizer_ -timeout 180m
=== RUN TestAccAWSIoTAuthorizer_basic
=== PAUSE TestAccAWSIoTAuthorizer_basic
=== RUN TestAccAWSIoTAuthorizer_disappears
=== PAUSE TestAccAWSIoTAuthorizer_disappears
=== RUN TestAccAWSIoTAuthorizer_SigningDisabled
=== PAUSE TestAccAWSIoTAuthorizer_SigningDisabled
=== RUN TestAccAWSIoTAuthorizer_Update
=== PAUSE TestAccAWSIoTAuthorizer_Update
=== CONT TestAccAWSIoTAuthorizer_basic
=== CONT TestAccAWSIoTAuthorizer_Update
=== CONT TestAccAWSIoTAuthorizer_SigningDisabled
=== CONT TestAccAWSIoTAuthorizer_disappears
--- PASS: TestAccAWSIoTAuthorizer_basic (37.34s)
--- PASS: TestAccAWSIoTAuthorizer_disappears (41.32s)
--- PASS: TestAccAWSIoTAuthorizer_SigningDisabled (56.25s)
--- PASS: TestAccAWSIoTAuthorizer_Update (62.92s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 66.121s
@Billlynch Thanks for the contribution 🎉 👏. |
…4671 Add missing CHANGELOG entry for #14671
This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #13412
Release note for CHANGELOG:
Output from acceptance testing: