Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_route53_resolver_rule domain_name value "." is now broken #14730

Closed
mingfang opened this issue Aug 19, 2020 · 6 comments · Fixed by #15015
Closed

aws_route53_resolver_rule domain_name value "." is now broken #14730

mingfang opened this issue Aug 19, 2020 · 6 comments · Fixed by #15015
Assignees
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/route53resolver Issues and PRs that pertain to the route53resolver service.
Milestone

Comments

@mingfang
Copy link

aws_route53_resolver_rule domain_name with value "." is legal and essential.
It was working until this commit.

ee459d6#diff-c728f6192d56e060a6fa9964d8d90832

that removed suppressRoute53ZoneNameWithTrailingDot() from aws/diff_suppress_funcs.go
This is a critical problem for me with no workarounds besides manually creating the rule.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 19, 2020
@ewbankkit ewbankkit added the service/route53resolver Issues and PRs that pertain to the route53resolver service. label Aug 20, 2020
@mingfang
Copy link
Author

I found that downgrading the AWS plugin can workaround this problem.

terraform {
  required_providers {
    aws = {
      source = "hashicorp/aws"
      version = "2.69.0"
    }
  }
}

@ewbankkit
Copy link
Contributor

Being able to create a rule for the . domain name is explicitly called out in the AWS documentation:

If you want to forward all queries to your network, you create a rule, specify "." (dot) for the domain name, and associate the rule with the VPCs for which you want to forward all DNS queries to your network.

@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2020
@ewbankkit
Copy link
Contributor

Attempting to create a rule with domain_name = "." results in the error:

        Error: error creating Route 53 Resolver rule: InvalidParameter: 1 validation error(s) found.
        - minimum field size of 1, CreateResolverRuleInput.DomainName.

@bflad
Copy link
Contributor

bflad commented Sep 3, 2020

The fix for this has been merged and will release with version 3.5.0 of the Terraform AWS Provider, very shortly. Thanks to @ewbankkit for the implementation. 👍

@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/route53resolver Issues and PRs that pertain to the route53resolver service.
Projects
None yet
3 participants