issue-1146 part b, add resource for emr_instance_fleet

[c4po]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1146

Release note for CHANGELOG:

* new resource: aws_emr_instance_fleet

acceptance test will depend on the 14788 be merged.
Output from acceptance testing:

% make testacc TESTARGS='-run=TestAccAWSEMRInstanceFleet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEMRInstanceFleet_basic -timeout 120m
=== RUN   TestAccAWSEMRInstanceFleet_basic
=== PAUSE TestAccAWSEMRInstanceFleet_basic
=== CONT  TestAccAWSEMRInstanceFleet_basic
2020/08/31 15:20:11 [INFO] Test: Using us-east-1 as test region
2020/08/31 15:20:11 [INFO] AWS Auth provider used: "EnvProvider"
--- PASS: TestAccAWSEMRInstanceFleet_basic (559.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	559.594s

 make testacc TESTARGS='-run=TestAccAWSEMRInstanceFleet_zero_count'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEMRInstanceFleet_zero_count -timeout 120m
=== RUN   TestAccAWSEMRInstanceFleet_zero_count
=== PAUSE TestAccAWSEMRInstanceFleet_zero_count
=== CONT  TestAccAWSEMRInstanceFleet_zero_count
2020/08/31 16:57:37 [INFO] Test: Using us-east-1 as test region
2020/08/31 16:57:37 [INFO] AWS Auth provider used: "EnvProvider"
--- PASS: TestAccAWSEMRInstanceFleet_zero_count (788.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	788.718s

% make testacc TESTARGS='-run=TestAccAWSEMRInstanceFleet_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEMRInstanceFleet_disappears -timeout 120m
=== RUN   TestAccAWSEMRInstanceFleet_disappears
=== PAUSE TestAccAWSEMRInstanceFleet_disappears
=== CONT  TestAccAWSEMRInstanceFleet_disappears
2020/09/01 09:37:25 [INFO] Test: Using us-east-1 as test region
2020/09/01 09:37:25 [INFO] AWS Auth provider used: "EnvProvider"
--- PASS: TestAccAWSEMRInstanceFleet_disappears (500.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	500.819s

[bflad]

Hi again 👋 Please see the below initial feedback and let us know if you have any questions or do not have time to implement the items. 👍

[bflad]

This is pretty close! Just needs import testing/documentation and left two other simplification suggestions. 👍 Acceptance testing is passing.

[bflad]

Looks great -- nice work @c4po 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEMRInstanceFleet_full (465.80s)
--- PASS: TestAccAWSEMRInstanceFleet_ebsBasic (475.54s)
--- PASS: TestAccAWSEMRInstanceFleet_disappears (486.69s)
--- PASS: TestAccAWSEMRInstanceFleet_basic (523.79s)
--- PASS: TestAccAWSEMRInstanceFleet_zero_count (559.72s)

[ghost]

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!