Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/waf_rate_based_rule: add rate_limit to the list of possible update changes #14964

Merged
merged 1 commit into from
Sep 2, 2020
Merged

resource/waf_rate_based_rule: add rate_limit to the list of possible update changes #14964

merged 1 commit into from
Sep 2, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Sep 1, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9659

Release note for CHANGELOG:

resource/waf_rate_based_rule: correctly update rate_limit

Output from acceptance testing:

--- PASS: TestAccAWSWafRateBasedRule_changeRateLimit (27.66s)

@anGie44 anGie44 requested a review from a team September 1, 2020 23:00
@ghost ghost added service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Sep 1, 2020
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Sep 1, 2020
@anGie44 anGie44 force-pushed the b-waf-rate-based-rule branch from a093066 to eb4aebd Compare September 1, 2020 23:04
@bflad bflad self-assigned this Sep 2, 2020
bflad
bflad approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Output from acceptance testing (failure fixed in #14958):

--- PASS: TestAccAWSWafRateBasedRule_basic (51.81s)
--- PASS: TestAccAWSWafRateBasedRule_disappears (61.17s)
--- PASS: TestAccAWSWafRateBasedRule_changeNameForceNew (87.88s)
--- FAIL: TestAccAWSWafRateBasedRule_changePredicates (92.42s)
--- PASS: TestAccAWSWafRateBasedRule_noPredicates (94.42s)
--- PASS: TestAccAWSWafRateBasedRule_changeRateLimit (97.72s)
--- PASS: TestAccAWSWafRateBasedRule_Tags (139.05s)

aws/resource_aws_waf_rate_based_rule_test.go Outdated Show resolved Hide resolved
@anGie44
Copy link
Contributor Author

anGie44 commented Sep 2, 2020 •
edited
Loading

Merged w/master and removed extra custom test function to determine TypeSet index in _changeRateLimit test.

Output of acceptance tests:

--- PASS: TestAccAWSWafRateBasedRule_changeRateLimit (38.17s)
--- PASS: TestAccAWSWafRateBasedRule_changePredicates (44.89s)
--- PASS: TestAccAWSWafRateBasedRule_changeNameForceNew (46.31s)
--- PASS: TestAccAWSWafRateBasedRule_noPredicates (20.85s)
--- PASS: TestAccAWSWafRateBasedRule_Tags (31.40s)
--- PASS: TestAccAWSWafRateBasedRule_disappears (37.98s)
--- PASS: TestAccAWSWafRateBasedRule_basic (39.36s)

@anGie44 anGie44 force-pushed the b-waf-rate-based-rule branch from 5768c4c to e8c0a25 Compare September 2, 2020 16:34
@anGie44 anGie44 force-pushed the b-waf-rate-based-rule branch from e8c0a25 to 2c3134b Compare September 2, 2020 16:42
@anGie44 anGie44 added this to the v3.5.0 milestone Sep 2, 2020
@anGie44 anGie44 merged commit 393eb26 into master Sep 2, 2020
@anGie44 anGie44 deleted the b-waf-rate-based-rule branch September 2, 2020 17:25
anGie44 added a commit that referenced this pull request Sep 2, 2020
@anGie44
Update CHANGELOG for #14964
147a7a7
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

aws_waf_rate_based_rule doesn't update rate_limit changes
2 participants
@anGie44 @bflad