Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CloudFront Field Level Encryption Configurations #15033

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4097
Requires #12509

Release note for CHANGELOG:

resource_aws_cloudfront_field_level_encryption_config: add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudfrontFieldLevelEncryptionConfig_'
--- PASS: TestAccAWSCloudfrontFieldLevelEncryptionConfig_basic (52.89s)
--- PASS: TestAccAWSCloudfrontFieldLevelEncryptionConfig_disappears (43.79s)

@DrFaust92 DrFaust92 requested a review from a team September 4, 2020 13:30
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Sep 4, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Sep 4, 2020
@DrFaust92 DrFaust92 marked this pull request as draft September 4, 2020 13:45
@DrFaust92 DrFaust92 marked this pull request as ready for review September 4, 2020 20:24
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@DrFaust92 DrFaust92 force-pushed the r/cloudfront_field_level_encryption_config branch 2 times, most recently from 499f875 to dbe398b Compare March 28, 2021 09:04
@DrFaust92 DrFaust92 force-pushed the r/cloudfront_field_level_encryption_config branch from b67652f to 838e829 Compare May 25, 2021 10:17
@DrFaust92 DrFaust92 force-pushed the r/cloudfront_field_level_encryption_config branch from 838e829 to 916d37b Compare May 27, 2021 19:56
@DrFaust92 DrFaust92 marked this pull request as draft September 10, 2021 16:55
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit
Copy link
Contributor

Changes included in #12509.

@ewbankkit ewbankkit closed this Nov 9, 2021
@DrFaust92 DrFaust92 deleted the r/cloudfront_field_level_encryption_config branch November 9, 2021 14:31
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support CloudFront Field Level Encryption Configurations
3 participants