Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/resource_aws_glue_crawler:remove-table_prefix #15268

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Sep 22, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15300

Release note for CHANGELOG:

resource/aws_glue_crawler: Allow removing `table_prefix`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCrawler_RemoveTablePrefix'
--- PASS: TestAccAWSGlueCrawler_RemoveTablePrefix (151.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       153.341s
...

@nikhil-goenka nikhil-goenka requested a review from a team September 22, 2020 13:56
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 22, 2020
@gdavison gdavison self-assigned this Sep 23, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Sep 23, 2020
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (73.61s)
--- PASS: TestAccAWSGlueCrawler_disappears (82.12s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (91.09s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (91.96s)
--- PASS: TestAccAWSGlueCrawler_S3Target (126.35s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (136.09s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (136.73s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (138.64s)
--- PASS: TestAccAWSGlueCrawler_Configuration (140.11s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (139.86s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (140.86s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (141.15s)
--- PASS: TestAccAWSGlueCrawler_Description (141.63s)
--- PASS: TestAccAWSGlueCrawler_RemoveTablePrefix (142.46s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (145.61s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (157.49s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (159.81s)
--- PASS: TestAccAWSGlueCrawler_Schedule (161.26s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (161.99s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (164.05s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (86.49s)
--- PASS: TestAccAWSGlueCrawler_Tags (104.77s)

@gdavison gdavison added this to the v3.8.0 milestone Sep 23, 2020
@gdavison gdavison merged commit 454a72b into hashicorp:master Sep 24, 2020
@nikhil-goenka nikhil-goenka deleted the f/resource_aws_glue_crawler-remove-table_prefix branch September 24, 2020 17:32
gdavison added a commit that referenced this pull request Sep 24, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/glue Issues and PRs that pertain to the glue service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to remove table_prefix from aws_glue_crawler
2 participants